You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/06 01:48:34 UTC
[GitHub] [spark] c21 opened a new pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
c21 opened a new pull request #34498:
URL: https://github.com/apache/spark/pull/34498
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
As a followup of https://github.com/apache/spark/pull/34298/files#r734795801, Similar to ORC aggregate push down, we can disallow split input files for Parquet reader as well. See original comment for more details of motivation. Also fix the string of `RowDataSourceScanExec` to only print out `PushedAggregates` and `PushedGroupby`, to be aligned with `PushedLimit` and `PushedSample`, as there's not so many queries can benefit from aggregate push down, so we don't need to print those unnecessary information.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Avoid unnecessary file splits in multiple tasks for Parquet reader with aggregate push down.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing unit test in `FileSourceAggregatePushDownSuite.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744076628
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +144,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
+ Map("PushedAggregates" -> seqToString(v.aggregateExpressions),
+ "PushedGroupby" -> seqToString(v.groupByColumns))} ++
Review comment:
nit: `PushedGroupBy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962507889
Thank you @sunchao, @huaxingao and @viirya for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962410793
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49420/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744206821
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScan.scala
##########
@@ -47,7 +47,11 @@ case class ParquetScan(
pushedAggregate: Option[Aggregation] = None,
partitionFilters: Seq[Expression] = Seq.empty,
dataFilters: Seq[Expression] = Seq.empty) extends FileScan {
- override def isSplitable(path: Path): Boolean = true
+ override def isSplitable(path: Path): Boolean = {
+ // If aggregate is pushed down, only the file footer will be read once,
+ // so file should not be split across multiple tasks.
+ pushedAggregate.isEmpty
Review comment:
Oh, okay. Got it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962388541
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744050012
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +151,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
Review comment:
hmm is this change necessary? are `aggString` and `groupByString` still used afterwards?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScan.scala
##########
@@ -47,7 +47,11 @@ case class ParquetScan(
pushedAggregate: Option[Aggregation] = None,
partitionFilters: Seq[Expression] = Seq.empty,
dataFilters: Seq[Expression] = Seq.empty) extends FileScan {
- override def isSplitable(path: Path): Boolean = true
+ override def isSplitable(path: Path): Boolean = {
+ // If aggregate is pushed down, only the file footer will be read once,
+ // so file should not be split across multiple tasks.
+ pushedAggregate.isEmpty
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744305297
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala
##########
@@ -92,11 +92,6 @@ case class ParquetPartitionReaderFactory(
ParquetFooterReader.readFooter(conf, filePath, SKIP_ROW_GROUPS)
} else {
// For aggregate push down, we will get max/min/count from footer statistics.
- // We want to read the footer for the whole file instead of reading multiple
- // footers for every split of the file. Basically if the start (the beginning of)
- // the offset in PartitionedFile is 0, we will read the footer. Otherwise, it means
- // that we have already read footer for that file, so we will skip reading again.
- if (file.start != 0) return null
Review comment:
> Quick question on: Existing unit test in FileSourceAggregatePushDownSuite.scala. How did the existing tests pass before this PR?
@HyukjinKwon - I think we are in the same page based on your latest comment, but just to be noisy here in case anything is missing. Before this PR, when a single file is split into multiple splits across multiple tasks, we have the logic here to only process the split of file if `file.start == 0`, so only the first split of file will be processed, and every file is processed only once. So here is the trick. Before this PR, the logic for Parquet aggregate push down was still correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962430920
**[Test build #144948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144948/testReport)** for PR 34498 at commit [`04c3f20`](https://github.com/apache/spark/commit/04c3f20cb4e3aef0a40283c5f4883e755f9a7f1b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962399310
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962387453
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao closed pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
sunchao closed pull request #34498:
URL: https://github.com/apache/spark/pull/34498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962413616
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49420/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962388541
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744206839
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScan.scala
##########
@@ -47,7 +47,11 @@ case class ParquetScan(
pushedAggregate: Option[Aggregation] = None,
partitionFilters: Seq[Expression] = Seq.empty,
dataFilters: Seq[Expression] = Seq.empty) extends FileScan {
- override def isSplitable(path: Path): Boolean = true
+ override def isSplitable(path: Path): Boolean = {
+ // If aggregate is pushed down, only the file footer will be read once,
+ // so file should not be split across multiple tasks.
+ pushedAggregate.isEmpty
Review comment:
Oh, okay. Got it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744305297
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala
##########
@@ -92,11 +92,6 @@ case class ParquetPartitionReaderFactory(
ParquetFooterReader.readFooter(conf, filePath, SKIP_ROW_GROUPS)
} else {
// For aggregate push down, we will get max/min/count from footer statistics.
- // We want to read the footer for the whole file instead of reading multiple
- // footers for every split of the file. Basically if the start (the beginning of)
- // the offset in PartitionedFile is 0, we will read the footer. Otherwise, it means
- // that we have already read footer for that file, so we will skip reading again.
- if (file.start != 0) return null
Review comment:
> Quick question on: Existing unit test in FileSourceAggregatePushDownSuite.scala. How did the existing tests pass before this PR?
@HyukjinKwon - I think we are in the same page based on your latest comment, but just to be noisy here in case anything is missing. Before this PR, when a single file is split into multiple splits across multiple tasks, we have the logic here to only process the split of file if `file.start == 0`, so only the first split of file will be processed, and every file is processed only once. So here is the trick. Before this PR, the logic for Parquet aggregate push down was still correct. We want to avoid unnecessary file splitting so update logic in this PR here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962378009
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962393467
**[Test build #144944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144944/testReport)** for PR 34498 at commit [`94a1bd4`](https://github.com/apache/spark/commit/94a1bd408a81bff45f788556475a6a4f5234aa63).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962391702
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49416/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744078327
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +151,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
Review comment:
@huaxingao - ah yes I forgot about the test. I am leaving `RowDataSourceScanExec` as it is for now, and we can discuss later, thanks for comment @sunchao and @huaxingao.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962433035
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144948/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744063753
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +151,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
Review comment:
The change looks good. I plan to fix this but didn't have a chance to do it yet. One problem, though. In the tests I check if the aggregate pushes down by checking the keywords in explain. If the explain contains `PushedAggregation: []`, then the aggregate is not pushed down. Since now we don't have the `[]`, some of the tests will fail. We probably should change all the tests to use a different method (collect aggregates in optimizedPlan) to check if aggregate push down. Probably do this in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744059657
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +151,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
Review comment:
Got it. This looks fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962368707
**[Test build #144944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144944/testReport)** for PR 34498 at commit [`94a1bd4`](https://github.com/apache/spark/commit/94a1bd408a81bff45f788556475a6a4f5234aa63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962366388
**[Test build #144942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144942/testReport)** for PR 34498 at commit [`4eb0e8d`](https://github.com/apache/spark/commit/4eb0e8d088c7bdc612257a759ab98977fffc802f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962364891
@huaxingao, @sunchao and @viirya - could you help take a look when you have time? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962379492
**[Test build #144945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144945/testReport)** for PR 34498 at commit [`3c54820`](https://github.com/apache/spark/commit/3c548203d78d74b4261c863a67f3d206ac07ec30).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962394183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962366388
**[Test build #144942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144942/testReport)** for PR 34498 at commit [`4eb0e8d`](https://github.com/apache/spark/commit/4eb0e8d088c7bdc612257a759ab98977fffc802f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962394182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962368707
**[Test build #144944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144944/testReport)** for PR 34498 at commit [`94a1bd4`](https://github.com/apache/spark/commit/94a1bd408a81bff45f788556475a6a4f5234aa63).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962379492
**[Test build #144945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144945/testReport)** for PR 34498 at commit [`3c54820`](https://github.com/apache/spark/commit/3c548203d78d74b4261c863a67f3d206ac07ec30).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962413616
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49420/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962556631
Quick question on:
> Existing unit test in `FileSourceAggregatePushDownSuite.scala.`
How did the existing tests pass before this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744305297
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala
##########
@@ -92,11 +92,6 @@ case class ParquetPartitionReaderFactory(
ParquetFooterReader.readFooter(conf, filePath, SKIP_ROW_GROUPS)
} else {
// For aggregate push down, we will get max/min/count from footer statistics.
- // We want to read the footer for the whole file instead of reading multiple
- // footers for every split of the file. Basically if the start (the beginning of)
- // the offset in PartitionedFile is 0, we will read the footer. Otherwise, it means
- // that we have already read footer for that file, so we will skip reading again.
- if (file.start != 0) return null
Review comment:
> Quick question on: Existing unit test in FileSourceAggregatePushDownSuite.scala. How did the existing tests pass before this PR?
@HyukjinKwon - I think we are in the same page based on your latest comment, but just to be noisy here in case anything is missing. Before this PR, when a single file is split into multiple splits across multiple tasks, we have the logic here to only process the split of file if `file.start == 0`, so only the first split of file will be processed, and every file is processed only once. So here is the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744076601
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +151,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
Review comment:
IMO it may be better to keep `[]` for empty aggregate/groupby, to be consistent with `PushedFilters` and those in `OrcScan`/`ParquetScan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962396007
**[Test build #144945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144945/testReport)** for PR 34498 at commit [`3c54820`](https://github.com/apache/spark/commit/3c548203d78d74b4261c863a67f3d206ac07ec30).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962399408
**[Test build #144948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144948/testReport)** for PR 34498 at commit [`04c3f20`](https://github.com/apache/spark/commit/04c3f20cb4e3aef0a40283c5f4883e755f9a7f1b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962399310
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962403613
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49420/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962399408
**[Test build #144948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144948/testReport)** for PR 34498 at commit [`04c3f20`](https://github.com/apache/spark/commit/04c3f20cb4e3aef0a40283c5f4883e755f9a7f1b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962433035
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144948/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #34498:
URL: https://github.com/apache/spark/pull/34498#discussion_r744050392
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -151,9 +151,10 @@ case class RowDataSourceScanExec(
Map(
"ReadSchema" -> requiredSchema.catalogString,
- "PushedFilters" -> seqToString(markedFilters.toSeq),
- "PushedAggregates" -> aggString,
- "PushedGroupby" -> groupByString) ++
+ "PushedFilters" -> seqToString(markedFilters.toSeq)) ++
+ pushedDownOperators.aggregation.fold(Map[String, String]()) { v =>
Review comment:
@sunchao - forget to remove `aggString` and `groupByString`. Removed. I think it'd better to align with `PushedLimit` and `PushedSample`. It's a minor change so packed here. I can make another minor PR if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962387360
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49416/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34498: [SPARK-37220][SQL] Do not split input file for Parquet reader with aggregate push down
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34498:
URL: https://github.com/apache/spark/pull/34498#issuecomment-962392759
**[Test build #144942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144942/testReport)** for PR 34498 at commit [`4eb0e8d`](https://github.com/apache/spark/commit/4eb0e8d088c7bdc612257a759ab98977fffc802f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org