You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Eric Shu <es...@pivotal.io> on 2017/05/31 23:21:24 UTC
Re: Review Request 59564: GEODE-2892 implement sizeOnSever and
isEmptyOnServer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59564/
-----------------------------------------------------------
(Updated May 31, 2017, 11:21 p.m.)
Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn Gallinat.
Changes
-------
Fix review comments. Added more test cases.
Bugs: GEODE-2892
https://issues.apache.org/jira/browse/GEODE-2892
Repository: geode
Description
-------
implement sizeOnSever and isEmptyOnServer
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/cache/Region.java 0fa29c6
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java e35750b
geode-core/src/main/java/org/apache/geode/internal/admin/remote/AdminRegion.java 51f1fdb
geode-core/src/main/java/org/apache/geode/internal/cache/LocalDataSet.java 8be8de1
geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java f581856
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/RegionCreation.java a107fb3
geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java f19c4e7
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionJUnitTest.java ce83165
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java 9ca5ab9
geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationTestCase.java d1eddbb
geode-core/src/test/java/org/apache/geode/security/SecurityTestUtils.java 2b26cdc
Diff: https://reviews.apache.org/r/59564/diff/2/
Changes: https://reviews.apache.org/r/59564/diff/1-2/
Testing (updated)
-------
precheckin
Thanks,
Eric Shu
Re: Review Request 59564: GEODE-2892 implement sizeOnSever and
isEmptyOnServer
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59564/#review176560
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/Region.java
Lines 2100 (patched)
<https://reviews.apache.org/r/59564/#comment249946>
Drop the "int". Do the same on the size javadocs
- Darrel Schneider
On May 31, 2017, 4:35 p.m., Eric Shu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59564/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 4:35 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn Gallinat.
>
>
> Bugs: GEODE-2892
> https://issues.apache.org/jira/browse/GEODE-2892
>
>
> Repository: geode
>
>
> Description
> -------
>
> implement sizeOnSever and isEmptyOnServer
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/Region.java 0fa29c6
> geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java e35750b
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/AdminRegion.java 51f1fdb
> geode-core/src/main/java/org/apache/geode/internal/cache/LocalDataSet.java 8be8de1
> geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java f581856
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/RegionCreation.java a107fb3
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java f19c4e7
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionJUnitTest.java ce83165
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java 9ca5ab9
> geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationTestCase.java d1eddbb
> geode-core/src/test/java/org/apache/geode/security/SecurityTestUtils.java 2b26cdc
>
>
> Diff: https://reviews.apache.org/r/59564/diff/3/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Eric Shu
>
>
Re: Review Request 59564: GEODE-2892 implement sizeOnSever and
isEmptyOnServer
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59564/#review176561
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On May 31, 2017, 4:35 p.m., Eric Shu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59564/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 4:35 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn Gallinat.
>
>
> Bugs: GEODE-2892
> https://issues.apache.org/jira/browse/GEODE-2892
>
>
> Repository: geode
>
>
> Description
> -------
>
> implement sizeOnSever and isEmptyOnServer
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/Region.java 0fa29c6
> geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java e35750b
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/AdminRegion.java 51f1fdb
> geode-core/src/main/java/org/apache/geode/internal/cache/LocalDataSet.java 8be8de1
> geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java f581856
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/RegionCreation.java a107fb3
> geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java f19c4e7
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionJUnitTest.java ce83165
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java 9ca5ab9
> geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationTestCase.java d1eddbb
> geode-core/src/test/java/org/apache/geode/security/SecurityTestUtils.java 2b26cdc
>
>
> Diff: https://reviews.apache.org/r/59564/diff/3/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Eric Shu
>
>
Re: Review Request 59564: GEODE-2892 implement sizeOnSever and
isEmptyOnServer
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59564/
-----------------------------------------------------------
(Updated May 31, 2017, 11:35 p.m.)
Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn Gallinat.
Changes
-------
Fix failure message in the test.
Bugs: GEODE-2892
https://issues.apache.org/jira/browse/GEODE-2892
Repository: geode
Description
-------
implement sizeOnSever and isEmptyOnServer
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/cache/Region.java 0fa29c6
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java e35750b
geode-core/src/main/java/org/apache/geode/internal/admin/remote/AdminRegion.java 51f1fdb
geode-core/src/main/java/org/apache/geode/internal/cache/LocalDataSet.java 8be8de1
geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java f581856
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/RegionCreation.java a107fb3
geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java f19c4e7
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionJUnitTest.java ce83165
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java 9ca5ab9
geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationTestCase.java d1eddbb
geode-core/src/test/java/org/apache/geode/security/SecurityTestUtils.java 2b26cdc
Diff: https://reviews.apache.org/r/59564/diff/3/
Changes: https://reviews.apache.org/r/59564/diff/2-3/
Testing
-------
precheckin
Thanks,
Eric Shu