You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Peter Courcoux <pe...@courcoux.biz> on 2003/06/13 23:43:29 UTC

[PATCH] UIManager

Hi,

I attach a patch for your consideration.

Skins for the UIManager were being corrupted by other users skins, when
the UIManager is being used as a session scoped tool. Turns out that the
Skin Properties are held in a static property of the class!

The patch simply removes the 'static' keyword.

Regards,

Peter

Index: UIManager.java
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine-2/src/java/org/apache/turbine/services/pull/util/UIManager.java,v
retrieving revision 1.9
diff -u -r1.9 UIManager.java
--- UIManager.java	3 Jun 2003 13:41:27 -0000	1.9
+++ UIManager.java	13 Jun 2003 21:32:48 -0000
@@ -182,7 +182,7 @@
      * Properties to hold the name/value pairs
      * for the skin.
      */
-    private static Properties skinProperties;
+    private Properties skinProperties;
 
     /**
      * Initialize the UIManager object.




-- 
Peter Courcoux <pe...@courcoux.biz>

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: [PATCH] UIManager

Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
Peter Courcoux <pe...@courcoux.biz> writes:

>Hi,

>I attach a patch for your consideration.

>Skins for the UIManager were being corrupted by other users skins, when
>the UIManager is being used as a session scoped tool. Turns out that the
>Skin Properties are held in a static property of the class!

>The patch simply removes the 'static' keyword.

Checked in. There were two more variables. Yes, this is definitely a
bug.

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

Java, perl, Solaris, Linux, xSP Consulting, Web Services 
freelance consultant -- Jakarta Turbine Development  -- hero for hire

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org