You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/19 15:07:32 UTC

[GitHub] [druid] kfaraz commented on a diff in pull request #12445: Fixes GCS based ingestion

kfaraz commented on code in PR #12445:
URL: https://github.com/apache/druid/pull/12445#discussion_r853188516


##########
core/src/main/java/org/apache/druid/data/input/impl/CloudObjectLocation.java:
##########
@@ -71,7 +71,7 @@ public CloudObjectLocation(@JsonProperty("bucket") String bucket, @JsonProperty(
 
   public CloudObjectLocation(URI uri)
   {
-    this(uri.getHost(), uri.getPath());
+    this(uri.getAuthority(), uri.getPath());

Review Comment:
   Yeah, I would be more comfortable with that too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org