[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #19774: [v1.x] Fix nightly CD for python docker image releases

[GitBox <gi...@apache.org>]

mseth10 commented on a change in pull request #19774:
URL: https://github.com/apache/incubator-mxnet/pull/19774#discussion_r585181937



##########
File path: cd/Jenkinsfile_utils.groovy
##########
@@ -19,16 +19,16 @@
 
 // Triggers a downstream jenkins job responsible for building, testing
 // and publishing all the variants for a particular 'job_type'.
-// The 'job_type' should be the name of the directory that contains the 
-// 'Jenkins_pipeline.groovy' file and has the pipeline definition for the 
+// The 'job_type' should be the name of the directory that contains the
+// 'Jenkins_pipeline.groovy' file and has the pipeline definition for the
 // artifact (docker image, binary, pypi or maven package, etc.) that should
 // be published.
 
 STATE_UPDATE="State Update"
 
-def trigger_release_job(job_name, job_type, mxnet_variants) {
+def trigger_release_job(cd_release_job, job_name, job_type, mxnet_variants) {

Review comment:
       CD_RELEASE_JOB_NAME is actually a parameter of the CD pipeline, so this is how it's supposed to be used. It is also set as a global env variable, which can potentially cause some issues.
   For reference, it is addressed in master by this PR https://github.com/apache/incubator-mxnet/pull/17775 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org