You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/06/11 18:46:42 UTC

[jira] [Created] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Ivan Kelly created BOOKKEEPER-292:
-------------------------------------

             Summary: Test backward compatibility automatically between versions.
                 Key: BOOKKEEPER-292
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
             Project: Bookkeeper
          Issue Type: Bug
            Reporter: Ivan Kelly
            Assignee: Ivan Kelly
             Fix For: 4.2.0


At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397069#comment-13397069 ] 

Ivan Kelly commented on BOOKKEEPER-292:
---------------------------------------

Ah, You saw this on your local machine? In that case, I guess it must be a maven version issue. What version are you using? I thought you were referring to the builds on https://builds.apache.org/job/bookkeeper-trunk/. One of them failed like this earlier today, but the rest were ok.
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397318#comment-13397318 ] 

Ivan Kelly commented on BOOKKEEPER-292:
---------------------------------------

Yup, readme does say maven 3, but i think we should work with maven 2 as well (we did up until this change). I'll have a look today to see if I can fix it.
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Mridul Muralidharan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397042#comment-13397042 ] 

Mridul Muralidharan commented on BOOKKEEPER-292:
------------------------------------------------

This fix breaks the build.
In particular, it introduces dependency issues :



$ mvn -DskipTests=true clean
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.apache.bookkeeper:bookkeeper-server'}' and 'Vertex{label='org.apache.bookkeeper:bookkeeper-server-compat400'}' introduces to cycle in the graph org.apache.bookkeeper:bookkeeper-server-compat400 --> org.apache.bookkeeper:bookkeeper-server --> org.apache.bookkeeper:bookkeeper-server-compat400
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1 second
[INFO] Finished at: Wed Jun 20 01:54:37 IST 2012
[INFO] Final Memory: 3M/26M
[INFO] ------------------------------------------------------------------------

                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13393682#comment-13393682 ] 

Sijie Guo commented on BOOKKEEPER-292:
--------------------------------------

the patch looks good. but seems that there is lots of tabs in newly added pom files.
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397065#comment-13397065 ] 

Ivan Kelly commented on BOOKKEEPER-292:
---------------------------------------

This only happened on one build. Those after are fine from this perspective. The reason they have failed though, is that i made findbugs errors a failing condition. Some have crept in to trunk, so they need to be fixed.
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Mridul Muralidharan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397315#comment-13397315 ] 

Mridul Muralidharan commented on BOOKKEEPER-292:
------------------------------------------------

My mistake, until now I was on Maven 2.2.1 and it had been working fine.
With this change, that is no longer the case ...

With 3.0.4, it works, but makes it tricky for my build environment - not all my projects are on 3.x :-)

Apologies for not reading README properly !
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396686#comment-13396686 ] 

Hudson commented on BOOKKEEPER-292:
-----------------------------------

Integrated in bookkeeper-trunk #568 (See [https://builds.apache.org/job/bookkeeper-trunk/568/])
    BOOKKEEPER-292: Test backward compatibility automatically between versions. (ivank) (Revision 1351651)

     Result = FAILURE
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/TestBackwardCompat.java
* /zookeeper/bookkeeper/trunk/compat-deps
* /zookeeper/bookkeeper/trunk/compat-deps/bookkeeper-server-compat-4.0.0
* /zookeeper/bookkeeper/trunk/compat-deps/bookkeeper-server-compat-4.0.0/pom.xml
* /zookeeper/bookkeeper/trunk/compat-deps/bookkeeper-server-compat-4.1.0
* /zookeeper/bookkeeper/trunk/compat-deps/bookkeeper-server-compat-4.1.0/pom.xml
* /zookeeper/bookkeeper/trunk/compat-deps/pom.xml
* /zookeeper/bookkeeper/trunk/pom.xml

                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Mridul Muralidharan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397066#comment-13397066 ] 

Mridul Muralidharan commented on BOOKKEEPER-292:
------------------------------------------------

When I tried with trunk from 30 mins back, it was still failing (as part of attempting to merge changes for jms provider branch with trunk).

                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397077#comment-13397077 ] 

Flavio Junqueira commented on BOOKKEEPER-292:
---------------------------------------------

I fresh copy of trunk does not give me any problem on my machine.
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396665#comment-13396665 ] 

Sijie Guo commented on BOOKKEEPER-292:
--------------------------------------

new patch is OK for me. +1 

Thanks Ivan for providing compatibility testing.
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-292:
----------------------------------

    Attachment: BOOKKEEPER-292.diff

Patch adds a new module for generating shaded[1] jars for the older versions of bookkeeper. These can then be used to test against the current version. 

This patch requires 4.1.0 to be able in public repositories to use. If it is not, do a mvn install from the 4.1 branch.
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-292) Test backward compatibility automatically between versions.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-292:
----------------------------------

    Attachment: BOOKKEEPER-292.diff

New patch removes tabs. 
                
> Test backward compatibility automatically between versions.
> -----------------------------------------------------------
>
>                 Key: BOOKKEEPER-292
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-292
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-292.diff, BOOKKEEPER-292.diff
>
>
> At the moment, backward compatibility between 4.1.0 and 4.0.0 can only be tested manually. This JIRA is the set up the code base, so we can validate behaviour between versions automatically, and spot if a change breaks functionallity between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira