You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Ferdy Galema (Created) (JIRA)" <ji...@apache.org> on 2012/02/15 10:35:59 UTC

[jira] [Created] (NUTCH-1279) Check if limit has been reached in GeneraterReducer must be the first check performance-wise.

Check if limit has been reached in GeneraterReducer must be the first check performance-wise.
---------------------------------------------------------------------------------------------

                 Key: NUTCH-1279
                 URL: https://issues.apache.org/jira/browse/NUTCH-1279
             Project: Nutch
          Issue Type: Improvement
          Components: generator
            Reporter: Ferdy Galema
            Priority: Minor
             Fix For: nutchgora


The (count >= limit) should be put up front in the reduce method of the generator, because that way when the limit is reached the reduce method will return faster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (NUTCH-1279) Check if limit has been reached in GeneraterReducer must be the first check performance-wise.

Posted by "Ferdy Galema (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ferdy Galema updated NUTCH-1279:
--------------------------------

    Attachment: NUTCH-1279.txt

Attached patch and committed.
                
> Check if limit has been reached in GeneraterReducer must be the first check performance-wise.
> ---------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-1279
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1279
>             Project: Nutch
>          Issue Type: Improvement
>          Components: generator
>            Reporter: Ferdy Galema
>            Priority: Minor
>             Fix For: nutchgora
>
>         Attachments: NUTCH-1279.txt
>
>
> The (count >= limit) should be put up front in the reduce method of the generator, because that way when the limit is reached the reduce method will return faster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (NUTCH-1279) Check if limit has been reached in GeneraterReducer must be the first check performance-wise.

Posted by "Ferdy Galema (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NUTCH-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ferdy Galema closed NUTCH-1279.
-------------------------------

    Resolution: Fixed
    
> Check if limit has been reached in GeneraterReducer must be the first check performance-wise.
> ---------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-1279
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1279
>             Project: Nutch
>          Issue Type: Improvement
>          Components: generator
>            Reporter: Ferdy Galema
>            Priority: Minor
>             Fix For: nutchgora
>
>         Attachments: NUTCH-1279.txt
>
>
> The (count >= limit) should be put up front in the reduce method of the generator, because that way when the limit is reached the reduce method will return faster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (NUTCH-1279) Check if limit has been reached in GeneraterReducer must be the first check performance-wise.

Posted by "Lewis John McGibbney (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NUTCH-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208341#comment-13208341 ] 

Lewis John McGibbney commented on NUTCH-1279:
---------------------------------------------

Hi Ferdy, have you checked whether this is the case in trunk as well? I know the fetcher architecture is slightly different.  
                
> Check if limit has been reached in GeneraterReducer must be the first check performance-wise.
> ---------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-1279
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1279
>             Project: Nutch
>          Issue Type: Improvement
>          Components: generator
>            Reporter: Ferdy Galema
>            Priority: Minor
>             Fix For: nutchgora
>
>         Attachments: NUTCH-1279.txt
>
>
> The (count >= limit) should be put up front in the reduce method of the generator, because that way when the limit is reached the reduce method will return faster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (NUTCH-1279) Check if limit has been reached in GeneraterReducer must be the first check performance-wise.

Posted by "Ferdy Galema (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NUTCH-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208354#comment-13208354 ] 

Ferdy Galema commented on NUTCH-1279:
-------------------------------------

Hi Lewis, I can confirm that trunk already uses the same optimization.
                
> Check if limit has been reached in GeneraterReducer must be the first check performance-wise.
> ---------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-1279
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1279
>             Project: Nutch
>          Issue Type: Improvement
>          Components: generator
>            Reporter: Ferdy Galema
>            Priority: Minor
>             Fix For: nutchgora
>
>         Attachments: NUTCH-1279.txt
>
>
> The (count >= limit) should be put up front in the reduce method of the generator, because that way when the limit is reached the reduce method will return faster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira