You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by GitBox <gi...@apache.org> on 2021/02/12 05:02:07 UTC

[GitHub] [nutch] lewismc opened a new pull request #569: NUTCH-2849 Replace remaining package.html files with package-info.java

lewismc opened a new pull request #569:
URL: https://github.com/apache/nutch/pull/569


   PR to address https://issues.apache.org/jira/browse/NUTCH-2849
   **failonwarning=true** flag now added... we have total Javadoc CI coverage.
   There are a few package-info.java files missing but we can get around to those again at some stage in the future. 
   Thanks @sebastian-nagel for the guidance on the last PR everything you said was correct. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nutch] lewismc commented on a change in pull request #569: NUTCH-2849 Replace remaining package.html files with package-info.java

Posted by GitBox <gi...@apache.org>.
lewismc commented on a change in pull request #569:
URL: https://github.com/apache/nutch/pull/569#discussion_r577051586



##########
File path: build.xml
##########
@@ -186,6 +186,7 @@
       doctitle="${name} ${version} API"
       bottom="Copyright &amp;copy; ${year} The Apache Software Foundation"
       failonerror="true"
+      failonwarning="true"

Review comment:
       Hi @sebastian-nagel in short no I am not able to reproduce.
   ```% ant clean runtime
   ...
     [javadoc] Standard Doclet version 1.8.0_221
     [javadoc] Building tree for all the packages and classes...
     [javadoc] Building index for all the packages and classes...
     [javadoc] Building index for all classes...
        [copy] Copying 1 file to /Users/lmcgibbn/Downloads/nutch/build/docs/api/org/apache/nutch/plugin/doc-files
        [copy] Copying 1 file to /Users/lmcgibbn/Downloads/nutch/build/docs/api/resources
        [copy] Copying 1 file to /Users/lmcgibbn/Downloads/nutch/build/docs/api/resources
   
   BUILD SUCCESSFUL
   Total time: 38 seconds
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nutch] lewismc merged pull request #569: NUTCH-2849 Replace remaining package.html files with package-info.java

Posted by GitBox <gi...@apache.org>.
lewismc merged pull request #569:
URL: https://github.com/apache/nutch/pull/569


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nutch] lewismc commented on a change in pull request #569: NUTCH-2849 Replace remaining package.html files with package-info.java

Posted by GitBox <gi...@apache.org>.
lewismc commented on a change in pull request #569:
URL: https://github.com/apache/nutch/pull/569#discussion_r577051254



##########
File path: build.xml
##########
@@ -809,6 +811,7 @@
       <classpath>
         <fileset dir="${build.plugins}" >
           <include name="**/*.jar"/>
+          <exclude name="any23/javax.annotation-api*.jar"/>

Review comment:
       Hi @sebastian-nagel in short no I am not able to reproduce.
   ```% ant clean runtime
   ...
     [javadoc] Standard Doclet version 1.8.0_221
     [javadoc] Building tree for all the packages and classes...
     [javadoc] Building index for all the packages and classes...
     [javadoc] Building index for all classes...
        [copy] Copying 1 file to /Users/lmcgibbn/Downloads/nutch/build/docs/api/org/apache/nutch/plugin/doc-files
        [copy] Copying 1 file to /Users/lmcgibbn/Downloads/nutch/build/docs/api/resources
        [copy] Copying 1 file to /Users/lmcgibbn/Downloads/nutch/build/docs/api/resources
   
   BUILD SUCCESSFUL
   Total time: 38 seconds
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nutch] sebastian-nagel commented on a change in pull request #569: NUTCH-2849 Replace remaining package.html files with package-info.java

Posted by GitBox <gi...@apache.org>.
sebastian-nagel commented on a change in pull request #569:
URL: https://github.com/apache/nutch/pull/569#discussion_r576824015



##########
File path: build.xml
##########
@@ -186,6 +186,7 @@
       doctitle="${name} ${version} API"
       bottom="Copyright &amp;copy; ${year} The Apache Software Foundation"
       failonerror="true"
+      failonwarning="true"

Review comment:
       Observed two warnings when running `ant clean javadoc` (which made the build to fail):
   ``` 
     [javadoc] .../src/java/org/apache/nutch/protocol/RobotRulesParser.java:58: warning - Tag @link: reference not found: getRobotRulesSet
     [javadoc] .../src/plugin/indexer-elastic/src/java/org/apache/nutch/indexwriter/elastic/ElasticIndexWriter.java:204: warning - Tag @link: reference not found: BulkProcessor.Listener
     ...
     [javadoc] 2 warnings
   
   BUILD FAILED
   .../build.xml:723: Javadoc issued warnings.
   ```

##########
File path: build.xml
##########
@@ -809,6 +811,7 @@
       <classpath>
         <fileset dir="${build.plugins}" >
           <include name="**/*.jar"/>
+          <exclude name="any23/javax.annotation-api*.jar"/>

Review comment:
       Ok. Nice, this solves the remaining "Multiple sources of package comments found" warning (see #568).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nutch] lewismc commented on a change in pull request #569: NUTCH-2849 Replace remaining package.html files with package-info.java

Posted by GitBox <gi...@apache.org>.
lewismc commented on a change in pull request #569:
URL: https://github.com/apache/nutch/pull/569#discussion_r577051792



##########
File path: build.xml
##########
@@ -186,6 +186,7 @@
       doctitle="${name} ${version} API"
       bottom="Copyright &amp;copy; ${year} The Apache Software Foundation"
       failonerror="true"
+      failonwarning="true"

Review comment:
       It looks like CI was not able to reproduce either...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org