[GitHub] npawar commented on a change in pull request #3868: Disable realtime aggregate metrics if multi value dimension present

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #3868: Disable realtime aggregate metrics if multi value dimension present
URL: https://github.com/apache/incubator-pinot/pull/3868#discussion_r259551114
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
 ##########
 @@ -715,13 +716,21 @@ private int getOrCreateDocId(Map<String, Object> dictIdMap) {
     }
 
     // All dimension columns should be dictionary encoded.
+    // All dimensions must be single value
     for (String dimension : schema.getDimensionNames()) {
       if (noDictionaryColumns.contains(dimension)) {
         _logger
             .warn("Metrics aggregation cannot be turned ON in presence of no-dictionary dimensions, eg: {}", dimension);
         _aggregateMetrics = false;
         break;
       }
+      // https://github.com/apache/incubator-pinot/issues/3867
+      if (!schema.getDimensionSpec(dimension).isSingleValueField()) {
 
 Review comment:
   i don't think so. The line where it's breaking right now is MutableSegmentImpl::672
   ```
   for (String column : _schema.getDimensionNames()) {
         dictIds[i++] = (Integer) dictIdMap.get(column);
       }
   ```
   It's checked only for dimensions and time. Unless I'm missing some other place?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org