You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/27 09:22:32 UTC
[GitHub] [doris] adonis0147 commented on a diff in pull request #13723: [Fix]Fix the extension mysql_to_doris BUG
adonis0147 commented on code in PR #13723:
URL: https://github.com/apache/doris/pull/13723#discussion_r1006620151
##########
extension/mysql_to_doris/bin/e_mysql_to_doris.sh:
##########
@@ -31,8 +31,8 @@ rm -f $path
#get create table sql for mysql
for table in $(cat ../conf/mysql_tables |grep -v '#' | awk -F '\n' '{print $1}')
do
- d_d=`echo $table` |awk -F '.' '{print $1}'
- d_t=`echo $table` |awk -F '.' '{print $2}'
+ d_d=`echo $table |awk -F '.' '{print $1}'`
+ d_t=`echo $table |awk -F '.' '{print $2}'`
Review Comment:
It is better to use this syntax.
```suggestion
d_d=$(echo $table |awk -F '.' '{print $1}')
d_t=$(echo $table |awk -F '.' '{print $2}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org