You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2015/08/20 17:25:35 UTC

svn commit: r1696807 - /lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/search/similarities/TestSimilarity2.java

Author: rmuir
Date: Thu Aug 20 15:25:35 2015
New Revision: 1696807

URL: http://svn.apache.org/r1696807
Log:
LUCENE-6711: improve test when it fails

Modified:
    lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/search/similarities/TestSimilarity2.java

Modified: lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/search/similarities/TestSimilarity2.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/search/similarities/TestSimilarity2.java?rev=1696807&r1=1696806&r2=1696807&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/search/similarities/TestSimilarity2.java (original)
+++ lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/search/similarities/TestSimilarity2.java Thu Aug 20 15:25:35 2015
@@ -30,6 +30,7 @@ import org.apache.lucene.index.RandomInd
 import org.apache.lucene.index.Term;
 import org.apache.lucene.search.BooleanClause;
 import org.apache.lucene.search.BooleanQuery;
+import org.apache.lucene.search.Explanation;
 import org.apache.lucene.search.IndexSearcher;
 import org.apache.lucene.search.Query;
 import org.apache.lucene.search.TermQuery;
@@ -177,10 +178,10 @@ public class TestSimilarity2 extends Luc
     Query query = queryBuilder.build();
     
     // collect scores
-    List<Float> scores = new ArrayList<>();
+    List<Explanation> scores = new ArrayList<>();
     for (Similarity sim : sims) {
       is.setSimilarity(sim);
-      scores.add(is.explain(query, 0).getValue());
+      scores.add(is.explain(query, 0));
     }
     ir.close();
     
@@ -195,7 +196,9 @@ public class TestSimilarity2 extends Luc
     is = newSearcher(ir);
     for (int i = 0; i < sims.size(); i++) {
       is.setSimilarity(sims.get(i));
-      assertEquals(scores.get(i).floatValue(), is.explain(query, 0).getValue(), 0F);
+      Explanation expected = scores.get(i);
+      Explanation actual = is.explain(query, 0);
+      assertEquals(sims.get(i).toString() + ": actual=" + actual + ",expected=" + expected, expected.getValue(), actual.getValue(), 0F);
     }
     
     iw.close();