[GitHub] [beam] tvalentyn commented on a diff in pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers

["tvalentyn (via GitHub)" <gi...@apache.org>]

tvalentyn commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296433672


##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN  \
     # Remove pip cache.
     rm -rf /root/.cache/pip
 
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+      apt-get install libgeos-dev ; \

Review Comment:
   i would suggest to move it to line 42, note that apt temp files are cleared, and this command might require a prior call to `apt update`.
   
   Also, did you run validatesconainerarm tests to verify this change ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org