[PATCH] DERBY-597 - Enhance ij connect statement to work in J2ME/CDC/FP

[Deepa Remesh <dr...@gmail.com>]

Hi,

I have submitted a patch for this and was wondering if someone can
review it please.

Thanks,
Deepa

Re: [PATCH] DERBY-597 - Enhance ij connect statement to work in J2ME/CDC/FP

[Deepa Remesh <dr...@gmail.com>]

I have submitted another patch for this last week. Can someone please
review this patch?

Thanks,
Deepa

Re: [PATCH] DERBY-597 - Enhance ij connect statement to work in J2ME/CDC/FP

[Daniel John Debrunner <dj...@debrunners.com>]

Deepa Remesh wrote:

> Hi,
> 
> I have submitted a patch for this and was wondering if someone can
> review it please.
> 
> Thanks,
> Deepa


Setting the database name from the connect as a System property is
probably not the way to go. It's a potential source for confusion as the
value set externally in the _app.properties is overriden. This might be
unexpected to someone trying to debug a test.

System.setProperty("ij.dataSource.databaseName",sVal);

I think the approach you take for the createDatabase property could alos
be used for the databaseName property, pass it into the setupDataSource
method. Though some additional comments on exactly what you are doing
with the create flag would be useful, e.g. how does it interact with the
ij.dataSource.createDatabase property?

Dan.