[GitHub] spark pull request: [SPARK-5311][core] Corrected EventLoggingListe...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4120#discussion_r24126352
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -86,8 +86,17 @@ private[spark] class EventLoggingListener(
        * Creates the log file in the configured log directory.
        */
       def start() {
    -    if (!fileSystem.isDirectory(new Path(logBaseDir))) {
    -      throw new IllegalArgumentException(s"Log directory $logBaseDir does not exist.")
    +    try {
    +      if (!fileSystem.getFileStatus(new Path(logBaseDir)).isDir()) {
    +        throw new IllegalArgumentException(s"Log directory $logBaseDir is not a directory.")
    +      }
    +    } catch {
    +      case ioe: FileNotFoundException => {
    +        logWarning(s"Log directory $logBaseDir does not exist. Creating with default file " +
    +          "permissions...")
    +        new File(logBaseDir).mkdir()
    --- End diff --
    
    We should remove this line, since we need to use `fileSystem` to create the file.  Also, I think we should use `mkdir` and not `mkdirs`, since I think that the old code failed if they didn't exist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org