[GitHub] [airflow] raphaelauv commented on a diff in pull request #29498: add missing read for K8S config file from conn in deferred `KubernetesPodOperator`

["raphaelauv (via GitHub)" <gi...@apache.org>]

raphaelauv commented on code in PR #29498:
URL: https://github.com/apache/airflow/pull/29498#discussion_r1104585339


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -565,7 +565,16 @@ def execute_async(self, context: Context):
 
     def convert_config_file_to_dict(self):
         """Converts passed config_file to dict format."""
-        config_file = self.config_file if self.config_file else os.environ.get(KUBE_CONFIG_ENV_VAR)
+        config_file = None

Review Comment:
   thanks @hussein-awala for proposing this fix.
   
   why the async need the function `convert_config_file_to_dict`and not the sync ?
   
   Look like the async was implemented not fully following this pattern -> https://github.com/apache/airflow/pull/20578
   
   your PR fix the problems for the extra `config_path` , there is a risk that another is missing or new in the future would need "manual" fix like this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org