[jira] [Commented] (HIVE-15051) Test framework integration with findbugs, rat checks etc.

["Lefty Leverenz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078925#comment-16078925 ] 

Lefty Leverenz commented on HIVE-15051:
---------------------------------------

Your doc looks good, [~pvary].  I made some trivial edits and added the release number.

By the way, this jira needs a fix version -- 3.0.0.

Two questions:

# What does this phrase mean in paragraph 3:  "... no full refactoring is required for change ..."?  I guess what puzzles me is the "for change" part.
# Why did you omit maven and javac from the Hive personality list, although they are in personality_plugins (dev-support/hive-personality.sh)?

Thanks.

> Test framework integration with findbugs, rat checks etc.
> ---------------------------------------------------------
>
>                 Key: HIVE-15051
>                 URL: https://issues.apache.org/jira/browse/HIVE-15051
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: beeline.out, HIVE-15051.02.patch, HIVE-15051.patch, Interim.patch, ql.out
>
>
> Find a way to integrate code analysis tools like findbugs, rat checks to PreCommit tests, thus removing the burden from reviewers to check the code style and other checks which could be done by code. 
> Might worth to take a look on Yetus, but keep in mind the Hive has a specific parallel test framework.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)