You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/07/06 08:00:36 UTC
[GitHub] [hop] VladimirAlexiev opened a new pull request, #1571: (DOC) more fixes in workflow/actions/workflow
VladimirAlexiev opened a new pull request, #1571:
URL: https://github.com/apache/hop/pull/1571
A couple more fixes to workflow/actions/workflow (see #1563)
- @hansva how to fix the bullets in `You can do this by:` to appear as list items? Maybe that's impossible in a table cell?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] VladimirAlexiev commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
VladimirAlexiev commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1175955336
Thanks @hansva I'll know for the future!
@gitmstoute can you weigh in on formatting of lists in tables?
In https://github.com/apache/hop/pull/1558/files you use `+` at the end of line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1175935598
yep, you beat me to it was just fixing it. Don't ask my why but you need to add an 'a' in front of the cell start
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
hansva merged PR #1571:
URL: https://github.com/apache/hop/pull/1571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1175938313
for more info on this https://docs.asciidoctor.org/asciidoc/latest/tables/format-cell-content/#a-operator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1175943354
My diff was being weird because it was merging your and my changes, I pushed the 'a' you can see it on line 36 of the jsoninput.adoc too.
<img width="878" alt="Screenshot 2022-07-06 at 10 33 20" src="https://user-images.githubusercontent.com/1140235/177507310-ae866332-a4cc-4088-a315-282ef21265a0.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1175945978
I do want to thank you for the thorough work, much appreciated @VladimirAlexiev !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] gitmstoute commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
gitmstoute commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1176196959
Correct @hansva @VladimirAlexiev , the documentation seems to be asciidoctor format, and the "+" at the end of a line is for a hard line break. Not sure if that's the best way, but it worked for fitting a list into a table cell.
https://docs.asciidoctor.org/asciidoc/latest/blocks/hard-line-breaks/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] VladimirAlexiev commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
VladimirAlexiev commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1175939862
@hansva But I haven't added an "a". https://github.com/apache/hop/edit/master/docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/jsoninput.adoc line 39 doesn't include an "a".
I just changed dashes to stars, and an extra trailing newline.
Please check what it looks like and add "a" if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] VladimirAlexiev commented on pull request #1571: (DOC) more fixes in workflow/actions/workflow
Posted by GitBox <gi...@apache.org>.
VladimirAlexiev commented on PR #1571:
URL: https://github.com/apache/hop/pull/1571#issuecomment-1175933763
fixes list `You can do this by:` using syntax from https://github.com/apache/hop/edit/master/docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/jsoninput.adoc line 39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org