[jira] [Work logged] (HIVE-21636) Performance cost when using replaceAll() vs replace()

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-21636?focusedWorklogId=444397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444397 ]

ASF GitHub Bot logged work on HIVE-21636:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jun/20 17:05
            Start Date: 11/Jun/20 17:05
    Worklog Time Spent: 10m 
      Work Description: belugabehr merged pull request #599:
URL: https://github.com/apache/hive/pull/599


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 444397)
    Time Spent: 20m  (was: 10m)

> Performance cost when using replaceAll() vs replace() 
> ------------------------------------------------------
>
>                 Key: HIVE-21636
>                 URL: https://issues.apache.org/jira/browse/HIVE-21636
>             Project: Hive
>          Issue Type: Improvement
>          Components: Accumulo Storage Handler, HCatalog, Vectorization
>            Reporter: bd2019us
>            Assignee: bd2019us
>            Priority: Trivial
>              Labels: pull-request-available
>         Attachments: HVIE-21636.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Use String.replace() instead of String.replaceAll() when replaceAll() does not use a regex
> replace() does not need extra compilation / performance overhead when a non-regex string is used. Thus changing replaceAll() to replace() can remove the associated performance overhead.
> Affected files:
> # accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/compare/StringCompare.java
> # hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java
> # vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java



--
This message was sent by Atlassian Jira
(v8.3.4#803005)