You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/04/26 02:47:23 UTC

[GitHub] [samza] shanthoosh commented on issue #1010: SAMZA-2176: Ignore the configurations with serialized null values from the coordinator stream.

shanthoosh commented on issue #1010: SAMZA-2176: Ignore the configurations with serialized null values from the coordinator stream.
URL: https://github.com/apache/samza/pull/1010#issuecomment-486906230
 
 
   @cameronlee314 
   In addition to introducing non-null checks for configuration, I also added non-null checks for all types of metadata in different utility class classes viz TaskAssignmentManager, `LocalityManager`, `TaskPartitionAssignmentManager` etc. 
   
   In the future, when someone by mistake writes serialized null(random-empty) for these other message types in coordinator stream, these null-checks would guard the application from failing. Please take a look when you get a chance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services