You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 20:18:57 UTC
[GitHub] [airflow] potiuk commented on a diff in pull request #26604: Update docs when not to use helm hooks for starting jobs
potiuk commented on code in PR #26604:
URL: https://github.com/apache/airflow/pull/26604#discussion_r978049933
##########
docs/helm-chart/index.rst:
##########
@@ -122,13 +122,15 @@ The command removes all the Kubernetes components associated with the chart and
.. note::
Some kubernetes resources created by the chart `helm hooks <https://helm.sh/docs/topics/charts_hooks/#hook-resources-are-not-managed-with-corresponding-releases>`__ might be left in the namespace after executing ``helm uninstall``, for example, ``brokerUrlSecret`` or ``fernetKeySecret``.
-Installing the Chart with Argo CD or Flux
------------------------------------------
+Installing the Chart with Argo CD, Flux or Terraform
+-----------------------------------------------------
-When installing the chart using Argo CD or Flux, you MUST set the two following values, or your application
+When installing the chart using Argo CD, Flux, or Terraform, you MUST set the two following values, or your application
will not start as the migrations will not be run:
.. code-block:: yaml
createUserJob.useHelmHooks: false
migrateDatabaseJob.useHelmHooks: false
+
+This also applies if you install the chart using `--wait` in your `helm install` command.
Review Comment:
```suggestion
This also applies if you install the chart using ``--wait`` in your ``helm install`` command.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org