You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/04/10 13:55:05 UTC

Review Request 58300: Remove singleNodeInstall flag from ambari-web code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58300/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-20723
    https://issues.apache.org/jira/browse/AMBARI-20723


Repository: ambari


Description
-------

Remove App.singleNodeInstall flag and all the related code from ambari-web as it's no more necessary.


Diffs
-----

  ambari-web/app/assets/test/tests.js ef8d0bc 
  ambari-web/app/config.js 47eb788 
  ambari-web/app/templates/main/service/services/oozie.hbs 3706eb4 
  ambari-web/app/views.js 3ed1a37 
  ambari-web/app/views/common/quick_view_link_view.js 3f3a3a3 
  ambari-web/app/views/main/service/info/summary.js 551a3fd 
  ambari-web/app/views/main/service/services/hbase.js d2716aa 
  ambari-web/app/views/main/service/services/hdfs.js 79208b9 
  ambari-web/app/views/main/service/services/oozie.js f7a645d 
  ambari-web/test/views/common/quick_link_view_test.js c0d58c8 
  ambari-web/test/views/main/service/info/summary_test.js 51fd2f2 
  ambari-web/test/views/main/service/services/hbase_test.js 6c0f1f1 
  ambari-web/test/views/main/service/services/hdfs_test.js 4de5f0b 
  ambari-web/test/views/main/service/services/oozie_test.js c95e65f 


Diff: https://reviews.apache.org/r/58300/diff/1/


Testing
-------

20669 passing (23s)
  128 pending


Thanks,

Andrii Babiichuk

Re: Review Request 58300: Remove singleNodeInstall flag from ambari-web code

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58300/#review171442
-----------------------------------------------------------


Ship it!




Ship It!

- Oleg Nechiporenko


On April 10, 2017, 1:55 p.m., Andrii Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58300/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 1:55 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-20723
>     https://issues.apache.org/jira/browse/AMBARI-20723
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove App.singleNodeInstall flag and all the related code from ambari-web as it's no more necessary.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js ef8d0bc 
>   ambari-web/app/config.js 47eb788 
>   ambari-web/app/templates/main/service/services/oozie.hbs 3706eb4 
>   ambari-web/app/views.js 3ed1a37 
>   ambari-web/app/views/common/quick_view_link_view.js 3f3a3a3 
>   ambari-web/app/views/main/service/info/summary.js 551a3fd 
>   ambari-web/app/views/main/service/services/hbase.js d2716aa 
>   ambari-web/app/views/main/service/services/hdfs.js 79208b9 
>   ambari-web/app/views/main/service/services/oozie.js f7a645d 
>   ambari-web/test/views/common/quick_link_view_test.js c0d58c8 
>   ambari-web/test/views/main/service/info/summary_test.js 51fd2f2 
>   ambari-web/test/views/main/service/services/hbase_test.js 6c0f1f1 
>   ambari-web/test/views/main/service/services/hdfs_test.js 4de5f0b 
>   ambari-web/test/views/main/service/services/oozie_test.js c95e65f 
> 
> 
> Diff: https://reviews.apache.org/r/58300/diff/1/
> 
> 
> Testing
> -------
> 
> 20669 passing (23s)
>   128 pending
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>