You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2020/08/08 12:04:07 UTC
[ofbiz-framework] branch trunk updated: Improved: Removed unused
imports from Java files for fixing checkstyle errors (OFBIZ-11930)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new b895a9c Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)
b895a9c is described below
commit b895a9c8894eb9ed07a9a774b36e8d09206a79ef
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Sat Aug 8 14:00:29 2020 +0200
Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)
Fixes few javadoc issues
Since this has been ignored for few commits I need to increase
tasks.checkstyleMain.maxErrors from 12224 to 12247 (did not check the detail)
---
build.gradle | 2 +-
.../apache/ofbiz/base/util/string/NodeELResolver.java | 13 +++++--------
.../java/org/apache/ofbiz/service/job/JobManager.java | 1 -
.../java/org/apache/ofbiz/service/job/JobPoller.java | 1 -
.../org/apache/ofbiz/webapp/control/ControlFilter.java | 1 -
.../org/apache/ofbiz/webapp/webdav/RequestHandler.java | 18 +++++++++++-------
6 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/build.gradle b/build.gradle
index ed871bc..cc563d8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -287,7 +287,7 @@ checkstyle {
// the sum of errors found last time it was changed after using the
// ‘checkstyle’ tool present in the framework and in the official
// plugins.
- tasks.checkstyleMain.maxErrors = 12224
+ tasks.checkstyleMain.maxErrors = 12247
// Currently there are a lot of errors so we need to temporarily
// hide them to avoid polluting the terminal output.
showViolations = false
diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/string/NodeELResolver.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/string/NodeELResolver.java
index 2a66c38..84749ab 100644
--- a/framework/base/src/main/java/org/apache/ofbiz/base/util/string/NodeELResolver.java
+++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/string/NodeELResolver.java
@@ -39,14 +39,11 @@ import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
/**
- * Defines property resolution behavior on Nodes. This resolver handles base objects that implement
- * org.w3c.dom.Node or org.apache.xerces.dom.NodeImpl. It accepts a String as a property and compiles
- * that String into an XPathExpression. The resulting value is the evaluation of the XPathExpression
- * in the context of the base Node. This resolver is currently only available in read-only mode, which
- * means that isReadOnly will always return true and {@link #setValue(ELContext, Object, Object, Object)}
- * will always throw PropertyNotWritableException. ELResolvers are combined together using {@link CompositeELResolver}
- * s, to define rich semantics for evaluating an expression. See the javadocs for {@link ELResolver}
- * for details.
+ * Defines property resolution behavior on Nodes. This resolver handles base objects that implement org.w3c.dom.Node or
+ * org.apache.xerces.dom.NodeImpl. It accepts a String as a property and compiles that String into an XPathExpression. The resulting value is the
+ * evaluation of the XPathExpression in the context of the base Node. This resolver is currently only available in read-only mode, which means that
+ * isReadOnly will always return true and {@link #setValue(ELContext, Object, Object, Object)} will always throw PropertyNotWritableException.
+ * ELResolvers are combined together to define rich semantics for evaluating an expression. See {@link ELResolver} for details.
*/
public class NodeELResolver extends ELResolver {
private final XPath xpath;
diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/job/JobManager.java b/framework/service/src/main/java/org/apache/ofbiz/service/job/JobManager.java
index 17908bf..fb029d3 100644
--- a/framework/service/src/main/java/org/apache/ofbiz/service/job/JobManager.java
+++ b/framework/service/src/main/java/org/apache/ofbiz/service/job/JobManager.java
@@ -357,7 +357,6 @@ public final class JobManager {
/** Queues a Job to run now.
* @throws IllegalStateException if the Job Manager is shut down.
- * @throws RejectedExecutionException if the poller is stopped.
*/
public void runJob(Job job) throws JobManagerException {
assertIsRunning();
diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPoller.java b/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPoller.java
index 8403476..dbc9ccb 100644
--- a/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPoller.java
+++ b/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPoller.java
@@ -206,7 +206,6 @@ public final class JobPoller implements ServiceConfigListener {
/**
* Adds a job to the job queue.
* @throws InvalidJobException if the job is in an invalid state.
- * @throws RejectedExecutionException if the poller is stopped.
*/
public void queueNow(Job job) throws InvalidJobException {
job.queue();
diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
index 4a4617d..df0dbd8 100644
--- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
+++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
@@ -125,7 +125,6 @@ public class ControlFilter extends HttpFilter {
/**
* Makes allowed paths pass through while redirecting the others to a fix location.
*
- * @see Filter#doFilter
*/
@Override
public void doFilter(HttpServletRequest req, HttpServletResponse resp, FilterChain chain)
diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/webdav/RequestHandler.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/webdav/RequestHandler.java
index def600b..bcf462b 100644
--- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/webdav/RequestHandler.java
+++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/webdav/RequestHandler.java
@@ -28,14 +28,18 @@ import javax.servlet.http.HttpServletResponse;
@FunctionalInterface
public interface RequestHandler {
/**
- * Method called by the the WebDAV servlet to handle a WebDAV request.
+ * Method called by the the WebDAV servlet to handle a WebDAV request.
*
- * @param req the HTTP request to handle which contains the {@link GenericDelegator delegator},
- * {@link LocalDispatcher dispatcher}, and {@link Security security} attributes
- * @param resp the HTTP response to send
- * @param ctx the context of the current servlet
- * @throws ServletException if servlet execution failed
- * @throws IOException if communication with the HTTP request/response buffers failed
+ * @param req
+ * the HTTP request to handle which contains the delegator, dispatcher}, Security attributes
+ * @param resp
+ * the HTTP response to send
+ * @param ctx
+ * the context of the current servlet
+ * @throws ServletException
+ * if servlet execution failed
+ * @throws IOException
+ * if communication with the HTTP request/response buffers failed
*/
void handleRequest(HttpServletRequest req, HttpServletResponse resp, ServletContext ctx)
throws ServletException, IOException;