You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/12 16:03:34 UTC
[GitHub] [dubbo-go] AlexStocks opened a new issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
AlexStocks opened a new issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152
<!-- Please only use this template for submitting enhancement requests -->
**What would you like to be added**:
upgrade gRPC version.
**Why is this needed**:
using latest gRPC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152#issuecomment-842010478
https://github.com/apache/dubbo-go/pull/1203 have updated etcd and grpc to latest version and it still needs
https://github.com/apache/dubbo-go/blob/65774dc90a6162c92acf89ae7a55972c604b9498/go.mod#L70
because of the consul depends the grpc v1.15.1.
But I think we can slow down the pace to update the verion of grpc, and focus on other issues. @AlexStocks @ztelur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152#issuecomment-817932711
cc @gaoxinge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152#issuecomment-822003065
> I think the difficult thing is that we should upgrade the version of `etcd`. This is because `etcd` does not use `go module` before `v3.5.0` ([[1](https://github.com/etcd-io/etcd/issues/11154)], [[2](https://colobu.com/2020/04/09/accidents-of-etcd-and-go-module/)]).
>
> Now the latest version of `github.com/coreos/etcd` is `v3.3.25+incompatible` ([[3](https://pkg.go.dev/go.etcd.io/etcd)]), and highest compatible version of grpc is `v1.26.0`. So we can not directly upgrade grpc to higher version.
>
> In addition, `github.com/coreos/etcd@v3.5.0` will release in the mid of 2021 ([[4](https://github.com/etcd-io/etcd/milestone/37)]), and it may introduce incompatible and conflict codes with `dubbogo`.
ok. I got what u said. let's keep this issue until the autumn of 2021.
we just upgrade gRPC to 1.26 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152#issuecomment-821990619
I think the difficult thing is that we should upgrade the version of `etcd`. This is because `etcd` does not use `go module` before `v3.5.0` ([[1](https://github.com/etcd-io/etcd/issues/11154)], [[2](https://colobu.com/2020/04/09/accidents-of-etcd-and-go-module/)]).
Now the latest version of `github.com/coreos/etcd` is `v3.3.25+incompatible` ([[3](https://pkg.go.dev/go.etcd.io/etcd)]), and highest compatible version of grpc is `v1.26.0`. So we can not directly upgrade grpc to higher version.
In addition, `github.com/coreos/etcd@v3.5.0` will release in the mid of 2021 ([[4](https://github.com/etcd-io/etcd/milestone/37)]), and it may introduce incompatible and conflict codes with `dubbogo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152#issuecomment-842010478
https://github.com/apache/dubbo-go/pull/1203 have updated etcd and grpc to latest version and it still needs
https://github.com/apache/dubbo-go/blob/65774dc90a6162c92acf89ae7a55972c604b9498/go.mod#L70
because of the consul depends the grpc v1.15.1.
But I think we can slow down the pace to update the verion of grpc, and focus on other issues. @AlexStocks @ztelur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge edited a comment on issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
gaoxinge edited a comment on issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152#issuecomment-841289250
I have updated grpc from 1.26.0 to 1.29.1. I will try to update it to 1.36 later. @AlexStocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge closed issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
gaoxinge closed issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge closed issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
gaoxinge closed issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on issue #1152: Ehancement: upgrade gRPC version from 1.26 to 1.36
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on issue #1152:
URL: https://github.com/apache/dubbo-go/issues/1152#issuecomment-841289250
I have updated grpc from 1.26.0 to 1.29.1. I will try to update it to 1.36 later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org