You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/03/16 13:39:14 UTC

[GitHub] [james-project] chibenwa commented on pull request #333: JAMES-3518: Method for docker file copy

chibenwa commented on pull request #333:
URL: https://github.com/apache/james-project/pull/333#issuecomment-800265953


   I guess the context is reuse of this class in an external project.
   
   Either the external use could:
   - use genericContainer directly
   - duplicate and adapt this class
   - maybe the smartest way around is to expose a method to manipulate the raw container (consumer<genericContainer>¿) and refactor this class to use it? This one would imo be the best option...
   
   We shall remove - and not write dead code.
   
   But james is also a toolkit to assemble email server. Imo we can introduce genericity not needed as part of james server as long as:
    - we test it
    - we document it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org