You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Philip Wilder (JIRA)" <de...@db.apache.org> on 2005/07/01 20:16:06 UTC
[jira] Updated: (DERBY-406) Client DataSource should not require user property to be set
[ http://issues.apache.org/jira/browse/DERBY-406?page=all ]
Philip Wilder updated DERBY-406:
--------------------------------
Attachment: Derby406_409_410.patch
A Combined patch for DERBY-406, DERBY-409 and DERBY-410
#Warning#
When testing this patch there were locale (en_CA vs en_US) and version (10.2.0.0 vs 10.1.0.0) issues which I believe to be unique to my machine. While this should not affect anyone who wishes to test this patch, running the derbynetclientmats suite would be advisable prior to commit.
For local the problem test was:
derbynet/sysinfo.java
For version info the problem tests were:
jdbcapi/dbMetaDataJdbc30.java
jdbcapi/metadata.java
jdbcapi/odbc_metadata.java
jdbcapi/metadataJdbc20.java
> Client DataSource should not require user property to be set
> ------------------------------------------------------------
>
> Key: DERBY-406
> URL: http://issues.apache.org/jira/browse/DERBY-406
> Project: Derby
> Type: Bug
> Components: Network Client
> Versions: 10.1.1.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Philip Wilder
> Attachments: DataSourceNoUser.java, Derby406_409_410.patch
>
> ClientDataSource should not require user to be set. It should default to user APP as described in:
> http://incubator.apache.org/derby/docs/adminguide/cadminappsclient.html
> This all seems to work ok for for DriverManager connections but fails for ClientDataSource
> run the attached repro
> $ java DataSourceNoUser
> embedded no userid/password
> client userid/password set
> client no password
> client no userid/no password
> org.apache.derby.client.am.SqlException: null userid not supported
> at org.apache.derby.client.net.NetConnection.checkUser(NetConnection.java:998)
> at org.apache.derby.client.net.NetConnection.flowConnect(NetConnection.java:380)
> at org.apache.derby.client.net.NetConnection.initialize(NetConnection.java:233)
> at org.apache.derby.client.net.NetConnection.<init>(NetConnection.java:201)
> at org.apache.derby.jdbc.ClientDataSource.getConnection(ClientDataSource.java:156)
> at org.apache.derby.jdbc.ClientDataSource.getConnection(ClientDataSource.java:135)
> at DataSourceNoUser.main(DataSourceNoUser.java:42)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-406) Client DataSource should not require
user property to be set
Posted by Daniel John Debrunner <dj...@debrunners.com>.
Philip Wilder (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-406?page=all ]
>
> Philip Wilder updated DERBY-406:
> --------------------------------
>
> Attachment: Derby406_409_410.patch
>
> A Combined patch for DERBY-406, DERBY-409 and DERBY-410
So how is this patch different to the one described early?
I would disagree with having a default value for password.
[Philip's earlier description]
> - Set password to a default value ("defaultpassword")
> - Set user to default to "APP"
> - Set the default servername to "localhost"
> - Changed the updateDataSourceValues of the ClientBaseDataSource class to update the password value if a password is found in the connection attributes.
> - Changed
> databaseName_ = dataSource.getDatabaseName() + attrString;
> to
> databaseName_ = dataSource.getDatabaseName() + ";" + attrString;
> in the connection class to avoid database names like myDBcreate=true when the setConnectionAttributes method is used.
> - Changed the dataSourcePermissions_net to include additional tests to check bug fixes and changed the associated.out file to match new output.
>
> Also with regards to the "Client data source published api javadoc cleanup" email sent out by Dan I changed the password, user and servername attributes to private so as to hopefully not conflict with his changes.
Actually, performing such a change yourself is more likely to cause
conflict. Just focus on your own changes don't try to pre-incorporate
other changes. :-)
Dan.
Re: [jira] Updated: (DERBY-406) Client DataSource should not require
user property to be set
Posted by Kathey Marsden <km...@sbcglobal.net>.
Philip Wilder (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-406?page=all ]
>
>Philip Wilder updated DERBY-406:
>--------------------------------
>
> Attachment: Derby406_409_410.patch
>
>A Combined patch for DERBY-406, DERBY-409 and DERBY-410
>
>#Warning#
>When testing this patch there were locale (en_CA vs en_US) and version (10.2.0.0 vs 10.1.0.0) issues which I believe to be unique to my machine. While this should not affect anyone who wishes to test this patch, running the derbynetclientmats suite would be advisable prior to commit.
>
>For local the problem test was:
>derbynet/sysinfo.java
>
>For version info the problem tests were:
>jdbcapi/dbMetaDataJdbc30.java
>jdbcapi/metadata.java
>jdbcapi/odbc_metadata.java
>jdbcapi/metadataJdbc20.java
>
>
>
I will look at this patch.