You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/28 13:12:59 UTC

[GitHub] [flink-ml] lindong28 opened a new pull request, #184: [hotfix] Update python tests to set execution.attached=True

lindong28 opened a new pull request, #184:
URL: https://github.com/apache/flink-ml/pull/184

   ## What is the purpose of the change
   
   All python tests are currently run with execution.attached=false by default. Thus `env.execute()` can return result before the execution finishes. This means that tests such as `RobustScalerTest::test_save_load_predict()` can start one job before the previous job finishes, with both jobs executed using the same StreamExecutionEnvironment instance.
   
   Currently StreamExecutionEnvironment is not thread-safe and it might fail if it is used in the manner described above. This PR sets execution.attached=True for all python tests so that `env.execute()` will only return after the job finishes.
   
   ## Brief change log
   
   Updates `PyFlinkMLTestCase` to configure StreamExecutionEnvironment with execution.attached=True.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1329985845

   Third round of tests failed due to NullPointerException from `RelMetadataQuery`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1329986916

   Fourth and Fifth rounds of tests succeeded.
   
   https://github.com/apache/flink-ml/actions/runs/3566599097
   
   https://github.com/apache/flink-ml/actions/runs/3568456675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1329205692

   The first round of tests has finished successfully. See https://github.com/apache/flink-ml/actions/runs/3565098067/jobs/5989846644


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1329970056

   Second round of tests failed due to `Py4JNetworkError("Answer from Java side is empty")`
   
   https://github.com/apache/flink-ml/actions/runs/3565699798/jobs/5991195736


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1330152353

   Thanks for the PR. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1330036570

   @HuangXingBo can you help review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 merged pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
zhipeng93 merged PR #184:
URL: https://github.com/apache/flink-ml/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1330034703

   @zhipeng93 @yunfengzhou-hub @jiangxin369 can you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #184: [hotfix] Update python tests to set execution.attached=True

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #184:
URL: https://github.com/apache/flink-ml/pull/184#issuecomment-1330034476

   The sixth round of tests succeeded.
   
   https://github.com/apache/flink-ml/actions/runs/3570261026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org