You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/22 19:38:03 UTC
[GitHub] [ozone] myskov opened a new pull request, #3873: HDDS-7381. Cleanup of VolumeManagerImpl
myskov opened a new pull request, #3873:
URL: https://github.com/apache/ozone/pull/3873
## What changes were proposed in this pull request?
I removed unused constructor arguments and cleanup javadoc comments (mostly removed duplicated ones)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7381
## How was this patch tested?
unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3873: HDDS-7381. Cleanup of VolumeManagerImpl
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3873:
URL: https://github.com/apache/ozone/pull/3873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Galsza commented on pull request #3873: HDDS-7381. Cleanup of VolumeManagerImpl
Posted by GitBox <gi...@apache.org>.
Galsza commented on PR #3873:
URL: https://github.com/apache/ozone/pull/3873#issuecomment-1290153525
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3873: HDDS-7381. Cleanup of VolumeManagerImpl
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3873:
URL: https://github.com/apache/ozone/pull/3873#issuecomment-1290619010
Thanks @myskov for the cleanup, @DaveTeng0, @dombizita, @Galsza for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3873: HDDS-7381. Cleanup of VolumeManagerImpl
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3873:
URL: https://github.com/apache/ozone/pull/3873#issuecomment-1289279504
@DaveTeng0 @Galsza @dombizita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Galsza commented on a diff in pull request #3873: HDDS-7381. Cleanup of VolumeManagerImpl
Posted by GitBox <gi...@apache.org>.
Galsza commented on code in PR #3873:
URL: https://github.com/apache/ozone/pull/3873#discussion_r1004066090
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/VolumeManagerImpl.java:
##########
@@ -36,31 +35,16 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * OM volume management code.
Review Comment:
Checkstyle error here, please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #3873: HDDS-7381. Cleanup of VolumeManagerImpl
Posted by GitBox <gi...@apache.org>.
dombizita commented on PR #3873:
URL: https://github.com/apache/ozone/pull/3873#issuecomment-1290200288
thanks for the patch @myskov, looks good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org