You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Szilard Nemethy <sn...@hortonworks.com> on 2014/11/21 20:16:41 UTC

Review Request 28343: Move master components related to Hive, Oozie

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28343/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Srimanth Gunturi.


Bugs: AMBARI-8417
    https://issues.apache.org/jira/browse/AMBARI-8417


Repository: ambari


Description
-------

Move master components related to Hive, Oozie


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 5cd67f5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 1b30a95 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/addMysqlUser.sh bd00c1f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/removeMysqlUser.sh PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 6df6059 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_users.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py c1279d8 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9b30cdb 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json f6e9570 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 4ddc718 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json b31d4b9 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json c8333ac 
  ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 0b7a3bb 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c60227b 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json a2c4fef 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json f1eefdb 
  ambari-web/app/controllers.js c4385ce 
  ambari-web/app/controllers/main/admin/highAvailability/progress_controller.js 04bdf08 
  ambari-web/app/controllers/main/service/info/configs.js 9333084 
  ambari-web/app/controllers/main/service/reassign/step1_controller.js 0a0bcbd 
  ambari-web/app/controllers/main/service/reassign/step4_controller.js 6141711 
  ambari-web/app/controllers/main/service/reassign/step6_controller.js a189a27 
  ambari-web/app/controllers/main/service/reassign/step7_controller.js PRE-CREATION 
  ambari-web/app/controllers/main/service/reassign_controller.js bbaf04b 
  ambari-web/app/data/HDP2/site_properties.js 2510408 
  ambari-web/app/messages.js 9943582 
  ambari-web/app/models/service/flume.js 4a76969 
  ambari-web/app/models/stack_service_component.js 5d62683 
  ambari-web/app/routes/reassign_master_routes.js e6ef5ca 
  ambari-web/app/templates/main/admin/highAvailability/progress.hbs b80650d 
  ambari-web/app/templates/main/service/reassign/step3.hbs 2eb85a8 
  ambari-web/app/templates/main/service/reassign/step7.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js d4a8402 
  ambari-web/app/views.js 586064f 
  ambari-web/app/views/main/admin/highAvailability/progress_view.js eaf8dda 
  ambari-web/app/views/main/service/reassign/step3_view.js 20b8323 
  ambari-web/app/views/main/service/reassign/step4_view.js 3ffdb4b 
  ambari-web/app/views/main/service/reassign/step5_view.js 5b7e53f 
  ambari-web/app/views/main/service/reassign/step7_view.js PRE-CREATION 
  ambari-web/app/views/main/service/reassign_view.js a90332a 
  ambari-web/app/views/wizard/controls_view.js a4cbf3f 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js d8f523c 
  ambari-web/test/controllers/main/service/reassign_controller_test.js 484ac83 
  ambari-web/test/models/stack_service_component_test.js b4e9195 

Diff: https://reviews.apache.org/r/28343/diff/


Testing
-------

Unit testing
E2E testing


Thanks,

Szilard Nemethy

Re: Review Request 28343: Move master components related to Hive, Oozie

Posted by Srimanth Gunturi <sr...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28343/#review62657
-----------------------------------------------------------


Since we are adding an extra page in UI, and changing the flow, can you please verify these changes do not effect moving of any other components?
Also, can you please write down what changes were made to the flow, and what the new page provides.


ambari-web/app/controllers/main/service/info/configs.js
<https://reviews.apache.org/r/28343/#comment104724>

    Remove debug code



ambari-web/app/controllers/main/service/reassign/step4_controller.js
<https://reviews.apache.org/r/28343/#comment104726>

    I do not see this being used anywhere in this patch. Needs cleanup.



ambari-web/app/controllers/main/service/reassign_controller.js
<https://reviews.apache.org/r/28343/#comment104727>

    Have all the components which can be reassigned, been tested with this new page in use?



ambari-web/app/views/main/service/reassign/step4_view.js
<https://reviews.apache.org/r/28343/#comment104725>

    Remove debug statements


- Srimanth Gunturi


On Nov. 21, 2014, 7:16 p.m., Szilard Nemethy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28343/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 7:16 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-8417
>     https://issues.apache.org/jira/browse/AMBARI-8417
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Move master components related to Hive, Oozie
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 5cd67f5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 1b30a95 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/addMysqlUser.sh bd00c1f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/removeMysqlUser.sh PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 6df6059 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_users.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py c1279d8 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9b30cdb 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json f6e9570 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 4ddc718 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json b31d4b9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json c8333ac 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 0b7a3bb 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c60227b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json a2c4fef 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json f1eefdb 
>   ambari-web/app/controllers.js c4385ce 
>   ambari-web/app/controllers/main/admin/highAvailability/progress_controller.js 04bdf08 
>   ambari-web/app/controllers/main/service/info/configs.js 9333084 
>   ambari-web/app/controllers/main/service/reassign/step1_controller.js 0a0bcbd 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 6141711 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js a189a27 
>   ambari-web/app/controllers/main/service/reassign/step7_controller.js PRE-CREATION 
>   ambari-web/app/controllers/main/service/reassign_controller.js bbaf04b 
>   ambari-web/app/data/HDP2/site_properties.js 2510408 
>   ambari-web/app/messages.js 9943582 
>   ambari-web/app/models/service/flume.js 4a76969 
>   ambari-web/app/models/stack_service_component.js 5d62683 
>   ambari-web/app/routes/reassign_master_routes.js e6ef5ca 
>   ambari-web/app/templates/main/admin/highAvailability/progress.hbs b80650d 
>   ambari-web/app/templates/main/service/reassign/step3.hbs 2eb85a8 
>   ambari-web/app/templates/main/service/reassign/step7.hbs PRE-CREATION 
>   ambari-web/app/utils/ajax/ajax.js d4a8402 
>   ambari-web/app/views.js 586064f 
>   ambari-web/app/views/main/admin/highAvailability/progress_view.js eaf8dda 
>   ambari-web/app/views/main/service/reassign/step3_view.js 20b8323 
>   ambari-web/app/views/main/service/reassign/step4_view.js 3ffdb4b 
>   ambari-web/app/views/main/service/reassign/step5_view.js 5b7e53f 
>   ambari-web/app/views/main/service/reassign/step7_view.js PRE-CREATION 
>   ambari-web/app/views/main/service/reassign_view.js a90332a 
>   ambari-web/app/views/wizard/controls_view.js a4cbf3f 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js d8f523c 
>   ambari-web/test/controllers/main/service/reassign_controller_test.js 484ac83 
>   ambari-web/test/models/stack_service_component_test.js b4e9195 
> 
> Diff: https://reviews.apache.org/r/28343/diff/
> 
> 
> Testing
> -------
> 
> Unit testing
> E2E testing
> 
> 
> Thanks,
> 
> Szilard Nemethy
> 
>

Re: Review Request 28343: Move master components related to Hive, Oozie

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28343/#review63807
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 2, 2014, 6:34 a.m., Szilard Nemethy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28343/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 6:34 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-8417
>     https://issues.apache.org/jira/browse/AMBARI-8417
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Move master components related to Hive, Oozie
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 5cd67f5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml 1b30a95 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/addMysqlUser.sh bd00c1f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/removeMysqlUser.sh PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_server.py 6df6059 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/mysql_users.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 6e44a0f 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9b30cdb 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json f6e9570 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 4ddc718 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json b31d4b9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json c8333ac 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 0b7a3bb 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c60227b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json a2c4fef 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json f1eefdb 
>   ambari-web/app/controllers.js 476b777 
>   ambari-web/app/controllers/main/admin/highAvailability/progress_controller.js 50e8979 
>   ambari-web/app/controllers/main/service/info/configs.js 88fe2c7 
>   ambari-web/app/controllers/main/service/reassign/step1_controller.js 0a0bcbd 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 6141711 
>   ambari-web/app/controllers/main/service/reassign/step7_controller.js PRE-CREATION 
>   ambari-web/app/controllers/main/service/reassign_controller.js bbaf04b 
>   ambari-web/app/data/HDP2/site_properties.js ecde26c 
>   ambari-web/app/messages.js e1fa969 
>   ambari-web/app/models/service/flume.js 4a76969 
>   ambari-web/app/models/stack_service_component.js 5d62683 
>   ambari-web/app/routes/reassign_master_routes.js 43563ea 
>   ambari-web/app/templates/main/admin/highAvailability/progress.hbs f543554 
>   ambari-web/app/templates/main/service/reassign/step1.hbs 9862cbe 
>   ambari-web/app/templates/main/service/reassign/step7.hbs PRE-CREATION 
>   ambari-web/app/utils/ajax/ajax.js 662c9b8 
>   ambari-web/app/views.js 3b45d59 
>   ambari-web/app/views/main/admin/highAvailability/progress_view.js 45cb00f 
>   ambari-web/app/views/main/service/reassign/step1_view.js ddabf14 
>   ambari-web/app/views/main/service/reassign/step5_view.js 5b7e53f 
>   ambari-web/app/views/main/service/reassign/step7_view.js PRE-CREATION 
>   ambari-web/app/views/main/service/reassign_view.js 47f1860 
>   ambari-web/app/views/wizard/controls_view.js a4cbf3f 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js d8f523c 
>   ambari-web/test/controllers/main/service/reassign_controller_test.js 484ac83 
>   ambari-web/test/models/stack_service_component_test.js b4e9195 
> 
> Diff: https://reviews.apache.org/r/28343/diff/
> 
> 
> Testing
> -------
> 
> Unit testing
> E2E testing
> 
> 
> Thanks,
> 
> Szilard Nemethy
> 
>