You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/13 00:54:48 UTC
Review Request 34126: Use JDK 8 language features.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-274
https://issues.apache.org/jira/browse/AURORA-274
Repository: aurora
Description
-------
Two code changes were required:
- a unit test made an assumption about iteration order over a `HashSet`
- a new compiler warning showed up on possible dereference of a null pointer
Note the first introduction of a lambda as a PoC while modifying a unit test.
Diffs
-----
NEWS PRE-CREATION
build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
Diff: https://reviews.apache.org/r/34126/diff/
Testing
-------
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh # TODO(wfarner): Report back, still executing.
```
Thanks,
Bill Farner
Re: Review Request 34126: Use JDK 8 language features.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/#review83516
-----------------------------------------------------------
Ship it!
src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java
<https://reviews.apache.org/r/34126/#comment134512>
Can't wait!
- Maxim Khutornenko
On May 12, 2015, 10:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34126/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 10:54 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-274
> https://issues.apache.org/jira/browse/AURORA-274
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Two code changes were required:
> - a unit test made an assumption about iteration order over a `HashSet`
> - a new compiler warning showed up on possible dereference of a null pointer
>
> Note the first introduction of a lambda as a PoC while modifying a unit test.
>
>
> Diffs
> -----
>
> NEWS PRE-CREATION
> build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
> examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
>
> Diff: https://reviews.apache.org/r/34126/diff/
>
>
> Testing
> -------
>
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh # TODO(wfarner): Report back, still executing.
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 34126: Use JDK 8 language features.
Posted by Bill Farner <wf...@apache.org>.
> On May 12, 2015, 11:14 p.m., Aurora ReviewBot wrote:
> > Master (c1b0dce) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
> > ../compiler/cpp/thrift --gen html -r ../tutorial/tutorial.thrift
> > make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
> > make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
> > Making all in tutorial
> > make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
> > make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
> > ../compiler/cpp/thrift --gen html -r ../tutorial/tutorial.thrift
> > make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
> > make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
> > make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
> > make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
> > make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
> > make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
> > make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
> > :api:classesThriftNote: Some input files use unchecked or unsafe operations.
> > Note: Recompile with -Xlint:unchecked for details.
> >
> > :api:checkPython
> > :api:generateThriftEntitiesJava
> > :api:classesThriftEntities
> > :api:compileJava UP-TO-DATE
> > :api:generateThriftResources
> > :api:processResources UP-TO-DATE
> > :api:classes
> > :api:jar
> > :compileJava FAILED
> >
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task ':compileJava'.
> > > invalid source release: 1.8
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> >
> > BUILD FAILED
> >
> > Total time: 1 mins 22.51 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Note: this is expected while we straddle the line between 7 and 8. After this lands, i will update the ReviewBot build to use 8.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/#review83515
-----------------------------------------------------------
On May 12, 2015, 10:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34126/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 10:54 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-274
> https://issues.apache.org/jira/browse/AURORA-274
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Two code changes were required:
> - a unit test made an assumption about iteration order over a `HashSet`
> - a new compiler warning showed up on possible dereference of a null pointer
>
> Note the first introduction of a lambda as a PoC while modifying a unit test.
>
>
> Diffs
> -----
>
> NEWS PRE-CREATION
> build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
> examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
>
> Diff: https://reviews.apache.org/r/34126/diff/
>
>
> Testing
> -------
>
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh # TODO(wfarner): Report back, still executing.
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 34126: Use JDK 8 language features.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/#review83515
-----------------------------------------------------------
Master (c1b0dce) is red with this patch.
./build-support/jenkins/build.sh
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
../compiler/cpp/thrift --gen html -r ../tutorial/tutorial.thrift
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
Making all in tutorial
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
../compiler/cpp/thrift --gen html -r ../tutorial/tutorial.thrift
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1/tutorial'
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:classesThriftNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> invalid source release: 1.8
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 22.51 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 12, 2015, 10:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34126/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 10:54 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-274
> https://issues.apache.org/jira/browse/AURORA-274
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Two code changes were required:
> - a unit test made an assumption about iteration order over a `HashSet`
> - a new compiler warning showed up on possible dereference of a null pointer
>
> Note the first introduction of a lambda as a PoC while modifying a unit test.
>
>
> Diffs
> -----
>
> NEWS PRE-CREATION
> build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
> examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
>
> Diff: https://reviews.apache.org/r/34126/diff/
>
>
> Testing
> -------
>
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh # TODO(wfarner): Report back, still executing.
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 34126: Use JDK 8 language features.
Posted by Bill Farner <wf...@apache.org>.
> On May 12, 2015, 11:08 p.m., Kevin Sweeney wrote:
> > examples/vagrant/provision-dev-cluster.sh, line 33
> > <https://reviews.apache.org/r/34126/diff/1/?file=957021#file957021line33>
> >
> > comment is a lie now, but it seems safe to remove as the update-alternatives line is self-explanatory
Thanks, removed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/#review83513
-----------------------------------------------------------
On May 12, 2015, 11:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34126/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 11:41 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-274
> https://issues.apache.org/jira/browse/AURORA-274
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Two code changes were required:
> - a unit test made an assumption about iteration order over a `HashSet`
> - a new compiler warning showed up on possible dereference of a null pointer
>
> Note the first introduction of a lambda as a PoC while modifying a unit test.
>
>
> Diffs
> -----
>
> NEWS PRE-CREATION
> build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
> examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
>
> Diff: https://reviews.apache.org/r/34126/diff/
>
>
> Testing
> -------
>
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 34126: Use JDK 8 language features.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/#review83513
-----------------------------------------------------------
Ship it!
examples/vagrant/provision-dev-cluster.sh
<https://reviews.apache.org/r/34126/#comment134511>
comment is a lie now, but it seems safe to remove as the update-alternatives line is self-explanatory
- Kevin Sweeney
On May 12, 2015, 3:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34126/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 3:54 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-274
> https://issues.apache.org/jira/browse/AURORA-274
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Two code changes were required:
> - a unit test made an assumption about iteration order over a `HashSet`
> - a new compiler warning showed up on possible dereference of a null pointer
>
> Note the first introduction of a lambda as a PoC while modifying a unit test.
>
>
> Diffs
> -----
>
> NEWS PRE-CREATION
> build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
> examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
> src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
>
> Diff: https://reviews.apache.org/r/34126/diff/
>
>
> Testing
> -------
>
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh # TODO(wfarner): Report back, still executing.
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 34126: Use JDK 8 language features.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/
-----------------------------------------------------------
(Updated May 12, 2015, 11:42 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-274
https://issues.apache.org/jira/browse/AURORA-274
Repository: aurora
Description
-------
Two code changes were required:
- a unit test made an assumption about iteration order over a `HashSet`
- a new compiler warning showed up on possible dereference of a null pointer
Note the first introduction of a lambda as a PoC while modifying a unit test.
Diffs (updated)
-----
NEWS PRE-CREATION
build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
Diff: https://reviews.apache.org/r/34126/diff/
Testing
-------
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
Bill Farner
Re: Review Request 34126: Use JDK 8 language features.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34126/
-----------------------------------------------------------
(Updated May 12, 2015, 11:41 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-274
https://issues.apache.org/jira/browse/AURORA-274
Repository: aurora
Description
-------
Two code changes were required:
- a unit test made an assumption about iteration order over a `HashSet`
- a new compiler warning showed up on possible dereference of a null pointer
Note the first introduction of a lambda as a PoC while modifying a unit test.
Diffs
-----
NEWS PRE-CREATION
build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc
examples/vagrant/provision-dev-cluster.sh 2c5ce970446f8849b66d7035b8b10b253827db83
src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java 218ae0da80f9129107da17004f23098b9507b33d
src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java d1301e0ea3c255563709048247772648052e8041
Diff: https://reviews.apache.org/r/34126/diff/
Testing (updated)
-------
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
Bill Farner