You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/22 19:52:23 UTC

[GitHub] [hudi] wangxianghu commented on a change in pull request #5096: [MINOR] Fix typo in MaxwellJsonKafkaSourcePostProcessor.Config#PRECOMBINE_FIELD_TYPE_PROP

wangxianghu commented on a change in pull request #5096:
URL: https://github.com/apache/hudi/pull/5096#discussion_r832568010



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/processor/maxwell/MaxwellJsonKafkaSourcePostProcessor.java
##########
@@ -91,7 +91,7 @@ public MaxwellJsonKafkaSourcePostProcessor(TypedProperties props) {
 
     public static final ConfigProperty<String> PRECOMBINE_FIELD_TYPE_PROP = ConfigProperty
         .key("hoodie.deltastreamer.source.json.kafka.post.processor.maxwell.precombine.field.type")
-        .defaultValue("DATA_STRING")
+        .defaultValue("DATE_STRING")
         .withDocumentation("Data type of the preCombine field. could be NON_TIMESTAMP, DATE_STRING,"
             + "UNIX_TIMESTAMP or EPOCHMILLISECONDS. DATA_STRING by default ");

Review comment:
       > Fix the docs as well?
   
   Good catch, Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org