You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "wmedvede (via GitHub)" <gi...@apache.org> on 2025/04/06 08:25:50 UTC
[PR] [sonataflow-operator] Knative outdated revisions are not cleaned-up for workflows with the knative deploymentModel and gitops profile [incubator-kie-tools]
wmedvede opened a new pull request, #3049:
URL: https://github.com/apache/incubator-kie-tools/pull/3049
Closes: #3048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-operator] Knative outdated revisions are not cleaned-up for workflows with the knative deploymentModel and gitops profile [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #3049:
URL: https://github.com/apache/incubator-kie-tools/pull/3049#discussion_r2031200000
##########
packages/sonataflow-operator/internal/controller/profiles/preview/states_preview.go:
##########
@@ -238,7 +229,10 @@ func (h *deployWithBuildWorkflowState) Do(ctx context.Context, workflow *operato
func (h *deployWithBuildWorkflowState) PostReconcile(ctx context.Context, workflow *operatorapi.SonataFlow) error {
// Clean up the outdated Knative revisions, if any
- return h.cleanupOutdatedRevisions(ctx, workflow)
+ if err := knative.CleanupOutdatedRevisions(ctx, h.C, h.Cfg, workflow); err != nil {
Review Comment:
You don't need to pass the client since it's globally accessible now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-operator] Knative outdated revisions are not cleaned-up for workflows with the knative deploymentModel and gitops profile [incubator-kie-tools]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede merged PR #3049:
URL: https://github.com/apache/incubator-kie-tools/pull/3049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [sonataflow-operator] Knative outdated revisions are not cleaned-up for workflows with the knative deploymentModel and gitops profile [incubator-kie-tools]
Posted by "wmedvede (via GitHub)" <gi...@apache.org>.
wmedvede commented on code in PR #3049:
URL: https://github.com/apache/incubator-kie-tools/pull/3049#discussion_r2031483842
##########
packages/sonataflow-operator/internal/controller/profiles/preview/states_preview.go:
##########
@@ -238,7 +229,10 @@ func (h *deployWithBuildWorkflowState) Do(ctx context.Context, workflow *operato
func (h *deployWithBuildWorkflowState) PostReconcile(ctx context.Context, workflow *operatorapi.SonataFlow) error {
// Clean up the outdated Knative revisions, if any
- return h.cleanupOutdatedRevisions(ctx, workflow)
+ if err := knative.CleanupOutdatedRevisions(ctx, h.C, h.Cfg, workflow); err != nil {
Review Comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org