[GitHub] [lucene] benwtrent commented on pull request #12004: Move byte vector queries into new KnnByteVectorQuery

[GitBox <gi...@apache.org>]

benwtrent commented on PR #12004:
URL: https://github.com/apache/lucene/pull/12004#issuecomment-1343454137

   @rmuir the first of the multiple refactors. 
   
   I attempted first to do it all in one change, but this proved to be an absolutely huge change (6k+ LOC churn) that spread across many parts of the code. Hopefully splitting it up like this makes reviewing simpler and allows us to iterate to the correct APIs for Byte and Float vectors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org