You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2021/11/12 14:29:11 UTC

[incubator-nuttx-apps] branch master updated (a4dd508 -> b345298)

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.


    from a4dd508  nshlib/nsh_proccmds.c: update ps_callback when get Group
     new 31ad83e  system/sched_note/Makefile:  Fix program name.
     new 49866a8  system/sched_note/note_main.c: Change the priority of errors printed through syslog.
     new e2975b5  system/sched_note/note_main.c: Drop the ERROR string from the syslog error messages as it's already prepended.
     new 610d387  system/sched_note/note_main.c:  Some cosmetic changes to comments.
     new b345298  system/sched_note/note_main.c: Fix the path of file in the header.

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 system/sched_note/Makefile    |  4 +--
 system/sched_note/note_main.c | 68 +++++++++++++++++++++----------------------
 2 files changed, 36 insertions(+), 36 deletions(-)

[incubator-nuttx-apps] 05/05: system/sched_note/note_main.c: Fix the path of file in the header.

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git

commit b3452982327c3308a4a45f4abb367e26f190f6a9
Author: Abdelatif Guettouche <ab...@espressif.com>
AuthorDate: Fri Nov 12 11:04:23 2021 +0100

    system/sched_note/note_main.c: Fix the path of file in the header.
    
    Signed-off-by: Abdelatif Guettouche <ab...@espressif.com>
---
 system/sched_note/note_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/sched_note/note_main.c b/system/sched_note/note_main.c
index 5f589fb..49f2108 100644
--- a/system/sched_note/note_main.c
+++ b/system/sched_note/note_main.c
@@ -1,5 +1,5 @@
 /************************************************************************************
- * apps/system/note/note_main.c
+ * apps/system/sched_note/note_main.c
  *
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with

[incubator-nuttx-apps] 01/05: system/sched_note/Makefile: Fix program name.

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git

commit 31ad83e018497f99ff9c2dc175faf275c705c728
Author: Abdelatif Guettouche <ab...@espressif.com>
AuthorDate: Thu Nov 11 15:13:14 2021 +0100

    system/sched_note/Makefile:  Fix program name.
    
    Signed-off-by: Abdelatif Guettouche <ab...@espressif.com>
---
 system/sched_note/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/system/sched_note/Makefile b/system/sched_note/Makefile
index 0074447..9b92e3b 100644
--- a/system/sched_note/Makefile
+++ b/system/sched_note/Makefile
@@ -20,14 +20,14 @@
 
 include $(APPDIR)/Make.defs
 
-# LED driver test built-in application info
+# Note driver test built-in application info
 
 PROGNAME = $(CONFIG_SYSTEM_NOTE_PROGNAME)
 PRIORITY = $(CONFIG_SYSTEM_NOTE_PRIORITY)
 STACKSIZE = $(CONFIG_SYSTEM_NOTE_STACKSIZE)
 MODULE = $(CONFIG_SYSTEM_NOTE)
 
-# LED driver test
+# Note driver test
 
 MAINSRC = note_main.c
 

[incubator-nuttx-apps] 02/05: system/sched_note/note_main.c: Change the priority of errors printed through syslog.

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git

commit 49866a8fe481ef343125dbbe994c1462dc39f64e
Author: Abdelatif Guettouche <ab...@espressif.com>
AuthorDate: Thu Nov 11 15:16:24 2021 +0100

    system/sched_note/note_main.c: Change the priority of errors printed
    through syslog.
    
    Errors should have LOG_ERR instead of LOG_INFO.
    
    Signed-off-by: Abdelatif Guettouche <ab...@espressif.com>
---
 system/sched_note/note_main.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/system/sched_note/note_main.c b/system/sched_note/note_main.c
index 4189c77..87e3205 100644
--- a/system/sched_note/note_main.c
+++ b/system/sched_note/note_main.c
@@ -128,7 +128,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length < sizeof(struct note_start_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: note too small for start note: %d\n",
                          note->nc_length);
                   return;
@@ -168,7 +168,7 @@ static void dump_notes(size_t nread)
             {
               if (note->nc_length != sizeof(struct note_stop_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for stop note: %d\n",
                          note->nc_length);
                   return;
@@ -196,7 +196,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length != sizeof(struct note_suspend_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for suspend note: %d\n",
                          note->nc_length);
                   return;
@@ -230,7 +230,7 @@ static void dump_notes(size_t nread)
             {
               if (note->nc_length != sizeof(struct note_resume_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for resume note: %d\n",
                          note->nc_length);
                   return;
@@ -259,7 +259,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length != sizeof(struct note_cpu_start_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for CPU start note: %d\n",
                          note->nc_length);
                   return;
@@ -278,7 +278,7 @@ static void dump_notes(size_t nread)
             {
               if (note->nc_length != sizeof(struct note_cpu_started_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for CPU started note: %d\n",
                          note->nc_length);
                   return;
@@ -299,7 +299,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length != sizeof(struct note_cpu_pause_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for CPU pause note: %d\n",
                          note->nc_length);
                   return;
@@ -318,7 +318,7 @@ static void dump_notes(size_t nread)
             {
               if (note->nc_length != sizeof(struct note_cpu_paused_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for CPU paused note: %d\n",
                          note->nc_length);
                   return;
@@ -339,7 +339,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length != sizeof(struct note_cpu_resume_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for CPU resume note: %d\n",
                          note->nc_length);
                   return;
@@ -358,7 +358,7 @@ static void dump_notes(size_t nread)
             {
               if (note->nc_length != sizeof(struct note_cpu_resumed_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for CPU resumed note: %d\n",
                          note->nc_length);
                   return;
@@ -383,7 +383,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length != sizeof(struct note_preempt_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for preemption note: %d\n",
                          note->nc_length);
                   return;
@@ -439,7 +439,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length != sizeof(struct note_csection_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for csection note: %d\n",
                          note->nc_length);
                   return;
@@ -497,7 +497,7 @@ static void dump_notes(size_t nread)
 
               if (note->nc_length != sizeof(struct note_spinlock_s))
                 {
-                  syslog(LOG_INFO,
+                  syslog(LOG_ERR,
                          "ERROR: Size incorrect for spinlock note: %d\n",
                          note->nc_length);
                   return;
@@ -633,7 +633,7 @@ static void dump_notes(size_t nread)
 
                     if (note->nc_length < SIZEOF_NOTE_SYSCALL_ENTER(0))
                       {
-                        syslog(LOG_INFO,
+                        syslog(LOG_ERR,
                                "ERROR: Size incorrect for SYSCALL enter note: %d\n",
                                note->nc_length);
                         return;
@@ -654,7 +654,7 @@ static void dump_notes(size_t nread)
 
                     if (note->nc_length != sizeof(struct note_syscall_leave_s))
                       {
-                        syslog(LOG_INFO,
+                        syslog(LOG_ERR,
                                "ERROR: Size incorrect for SYSCALL leave note: %d\n",
                                note->nc_length);
                         return;
@@ -691,7 +691,7 @@ static void dump_notes(size_t nread)
 
                     if (note->nc_length != sizeof(struct note_irqhandler_s))
                       {
-                        syslog(LOG_INFO,
+                        syslog(LOG_ERR,
                                "ERROR: Size incorrect for IRQ note: %d\n",
                                note->nc_length);
                         return;
@@ -736,7 +736,7 @@ static int note_daemon(int argc, char *argv[])
   if (fd < 0)
     {
       int errcode = errno;
-      syslog(LOG_INFO, "note_daemon: ERROR: Failed to open /dev/note: %d\n",
+      syslog(LOG_ERR, "note_daemon: ERROR: Failed to open /dev/note: %d\n",
              errcode);
       goto errout;
     }

[incubator-nuttx-apps] 03/05: system/sched_note/note_main.c: Drop the ERROR string from the syslog error messages as it's already prepended.

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git

commit e2975b5947497c4cf28e2ac5b7bb29b649f31211
Author: Abdelatif Guettouche <ab...@espressif.com>
AuthorDate: Thu Nov 11 15:18:07 2021 +0100

    system/sched_note/note_main.c: Drop the ERROR string from the syslog
    error messages as it's already prepended.
    
    Signed-off-by: Abdelatif Guettouche <ab...@espressif.com>
---
 system/sched_note/note_main.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/system/sched_note/note_main.c b/system/sched_note/note_main.c
index 87e3205..3e40baf 100644
--- a/system/sched_note/note_main.c
+++ b/system/sched_note/note_main.c
@@ -129,7 +129,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length < sizeof(struct note_start_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: note too small for start note: %d\n",
+                         "note too small for start note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -169,7 +169,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_stop_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for stop note: %d\n",
+                         "Size incorrect for stop note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -197,7 +197,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_suspend_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for suspend note: %d\n",
+                         "Size incorrect for suspend note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -231,7 +231,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_resume_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for resume note: %d\n",
+                         "Size incorrect for resume note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -260,7 +260,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_start_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for CPU start note: %d\n",
+                         "Size incorrect for CPU start note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -279,7 +279,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_started_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for CPU started note: %d\n",
+                         "Size incorrect for CPU started note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -300,7 +300,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_pause_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for CPU pause note: %d\n",
+                         "Size incorrect for CPU pause note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -319,7 +319,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_paused_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for CPU paused note: %d\n",
+                         "Size incorrect for CPU paused note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -340,7 +340,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_resume_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for CPU resume note: %d\n",
+                         "Size incorrect for CPU resume note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -359,7 +359,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_resumed_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for CPU resumed note: %d\n",
+                         "Size incorrect for CPU resumed note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -384,7 +384,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_preempt_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for preemption note: %d\n",
+                         "Size incorrect for preemption note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -440,7 +440,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_csection_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for csection note: %d\n",
+                         "Size incorrect for csection note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -498,7 +498,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_spinlock_s))
                 {
                   syslog(LOG_ERR,
-                         "ERROR: Size incorrect for spinlock note: %d\n",
+                         "Size incorrect for spinlock note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -634,7 +634,7 @@ static void dump_notes(size_t nread)
                     if (note->nc_length < SIZEOF_NOTE_SYSCALL_ENTER(0))
                       {
                         syslog(LOG_ERR,
-                               "ERROR: Size incorrect for SYSCALL enter note: %d\n",
+                               "Size incorrect for SYSCALL enter note: %d\n",
                                note->nc_length);
                         return;
                       }
@@ -655,7 +655,7 @@ static void dump_notes(size_t nread)
                     if (note->nc_length != sizeof(struct note_syscall_leave_s))
                       {
                         syslog(LOG_ERR,
-                               "ERROR: Size incorrect for SYSCALL leave note: %d\n",
+                               "Size incorrect for SYSCALL leave note: %d\n",
                                note->nc_length);
                         return;
                       }
@@ -692,7 +692,7 @@ static void dump_notes(size_t nread)
                     if (note->nc_length != sizeof(struct note_irqhandler_s))
                       {
                         syslog(LOG_ERR,
-                               "ERROR: Size incorrect for IRQ note: %d\n",
+                               "Size incorrect for IRQ note: %d\n",
                                note->nc_length);
                         return;
                       }

[incubator-nuttx-apps] 04/05: system/sched_note/note_main.c: Some cosmetic changes to comments.

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git

commit 610d3878afc8997d74f73fa7c2547f18e13428ee
Author: Abdelatif Guettouche <ab...@espressif.com>
AuthorDate: Thu Nov 11 15:23:46 2021 +0100

    system/sched_note/note_main.c:  Some cosmetic changes to comments.
    
    Signed-off-by: Abdelatif Guettouche <ab...@espressif.com>
---
 system/sched_note/note_main.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/system/sched_note/note_main.c b/system/sched_note/note_main.c
index 3e40baf..5f589fb 100644
--- a/system/sched_note/note_main.c
+++ b/system/sched_note/note_main.c
@@ -129,7 +129,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length < sizeof(struct note_start_s))
                 {
                   syslog(LOG_ERR,
-                         "note too small for start note: %d\n",
+                         "Note too small for \"Start\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -169,7 +169,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_stop_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for stop note: %d\n",
+                         "Size incorrect for \"Stop\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -197,7 +197,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_suspend_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for suspend note: %d\n",
+                         "Size incorrect for \"Suspend\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -231,7 +231,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_resume_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for resume note: %d\n",
+                         "Size incorrect for \"Resume\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -260,7 +260,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_start_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for CPU start note: %d\n",
+                         "Size incorrect for \"CPU Start\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -279,7 +279,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_started_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for CPU started note: %d\n",
+                         "Size incorrect for \"CPU started\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -300,7 +300,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_pause_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for CPU pause note: %d\n",
+                         "Size incorrect for \"CPU pause\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -319,7 +319,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_paused_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for CPU paused note: %d\n",
+                         "Size incorrect for \"CPU paused\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -340,7 +340,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_resume_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for CPU resume note: %d\n",
+                         "Size incorrect for \"CPU resume\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -359,7 +359,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_cpu_resumed_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for CPU resumed note: %d\n",
+                         "Size incorrect for \"CPU resumed\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -384,7 +384,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_preempt_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for preemption note: %d\n",
+                         "Size incorrect for \"Preemption\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -440,7 +440,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_csection_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for csection note: %d\n",
+                         "Size incorrect for \"csection\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -498,7 +498,7 @@ static void dump_notes(size_t nread)
               if (note->nc_length != sizeof(struct note_spinlock_s))
                 {
                   syslog(LOG_ERR,
-                         "Size incorrect for spinlock note: %d\n",
+                         "Size incorrect for \"Spinlock\" note: %d\n",
                          note->nc_length);
                   return;
                 }
@@ -634,7 +634,7 @@ static void dump_notes(size_t nread)
                     if (note->nc_length < SIZEOF_NOTE_SYSCALL_ENTER(0))
                       {
                         syslog(LOG_ERR,
-                               "Size incorrect for SYSCALL enter note: %d\n",
+                               "Size incorrect for \"SYSCALL enter\" note: %d\n",
                                note->nc_length);
                         return;
                       }
@@ -655,7 +655,7 @@ static void dump_notes(size_t nread)
                     if (note->nc_length != sizeof(struct note_syscall_leave_s))
                       {
                         syslog(LOG_ERR,
-                               "Size incorrect for SYSCALL leave note: %d\n",
+                               "Size incorrect for \"SYSCALL leave\" note: %d\n",
                                note->nc_length);
                         return;
                       }
@@ -692,7 +692,7 @@ static void dump_notes(size_t nread)
                     if (note->nc_length != sizeof(struct note_irqhandler_s))
                       {
                         syslog(LOG_ERR,
-                               "Size incorrect for IRQ note: %d\n",
+                               "Size incorrect for \"IRQ\" note: %d\n",
                                note->nc_length);
                         return;
                       }