You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2011/05/25 13:36:47 UTC
[jira] [Created] (LUCENE-3143) SegmentMerger should assert .del and
.s* files are not passed to createCompoundFile
SegmentMerger should assert .del and .s* files are not passed to createCompoundFile
-----------------------------------------------------------------------------------
Key: LUCENE-3143
URL: https://issues.apache.org/jira/browse/LUCENE-3143
Project: Lucene - Java
Issue Type: Bug
Components: core/index
Reporter: Shai Erera
Assignee: Shai Erera
Priority: Minor
Fix For: 3.2, 4.0
Spinoff from LUCENE-3126. SegmentMerger.createCompoundFile does not document that it should not receive files that are not included in the .cfs, such as .del and .s* (separate norms). Today, that method is called from code which ensures that, but we should:
# Add some documentation to clarify that.
# Add some asserts so that if a test (or other code, running w/ -ea) does that, we catch it.
Will post a patch soon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3143) SegmentMerger should assert .del and
.s* files are not passed to createCompoundFile
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-3143:
-------------------------------
Attachment: LUCENE-3143.patch
Patch against 3x, adds asserts to SM + test to ensure they are not allowed. All core tests pass.
> SegmentMerger should assert .del and .s* files are not passed to createCompoundFile
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-3143
> URL: https://issues.apache.org/jira/browse/LUCENE-3143
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3143.patch
>
>
> Spinoff from LUCENE-3126. SegmentMerger.createCompoundFile does not document that it should not receive files that are not included in the .cfs, such as .del and .s* (separate norms). Today, that method is called from code which ensures that, but we should:
> # Add some documentation to clarify that.
> # Add some asserts so that if a test (or other code, running w/ -ea) does that, we catch it.
> Will post a patch soon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3143) SegmentMerger should assert .del
and .s* files are not passed to createCompoundFile
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera resolved LUCENE-3143.
--------------------------------
Resolution: Fixed
bq. Maybe sharpen the comment to something like
Thanks Mike. Changed as you suggest.
Committed revision 1127601 (3x).
Committed revision 1127602 (trunk).
> SegmentMerger should assert .del and .s* files are not passed to createCompoundFile
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-3143
> URL: https://issues.apache.org/jira/browse/LUCENE-3143
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3143.patch
>
>
> Spinoff from LUCENE-3126. SegmentMerger.createCompoundFile does not document that it should not receive files that are not included in the .cfs, such as .del and .s* (separate norms). Today, that method is called from code which ensures that, but we should:
> # Add some documentation to clarify that.
> # Add some asserts so that if a test (or other code, running w/ -ea) does that, we catch it.
> Will post a patch soon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3143) SegmentMerger should assert .del
and .s* files are not passed to createCompoundFile
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039171#comment-13039171 ]
Michael McCandless commented on LUCENE-3143:
--------------------------------------------
Looks good!
Maybe sharpen the comment to something like: this method creates a compound file for all files returned by info.files(). While, generally, this may include separate norms and deletion files, this SegmentInfo must not reference such files when this method is called, because they are not allowed within a compound file. Something like that...?
> SegmentMerger should assert .del and .s* files are not passed to createCompoundFile
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-3143
> URL: https://issues.apache.org/jira/browse/LUCENE-3143
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3143.patch
>
>
> Spinoff from LUCENE-3126. SegmentMerger.createCompoundFile does not document that it should not receive files that are not included in the .cfs, such as .del and .s* (separate norms). Today, that method is called from code which ensures that, but we should:
> # Add some documentation to clarify that.
> # Add some asserts so that if a test (or other code, running w/ -ea) does that, we catch it.
> Will post a patch soon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org