[GitHub] [kafka] TaklaGerguis commented on a diff in pull request #13897: KAFKA-14133: Migrate StateDirectory mock in TaskManagerTest to Mockito

["TaklaGerguis (via GitHub)" <gi...@apache.org>]

TaklaGerguis commented on code in PR #13897:
URL: https://github.com/apache/kafka/pull/13897#discussion_r1237176915


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -3474,14 +3453,13 @@ public void shouldNotCommitActiveAndStandbyTasksWhileRebalanceInProgress() throw
         final StateMachineTask task01 = new StateMachineTask(taskId01, taskId01Partitions, false);
 
         makeTaskFolders(taskId00.toString(), task01.toString());
-        expectLockObtainedFor(taskId00, taskId01);

Review Comment:
   This was reported by Mockito as an unnecessary stubbing. I checked the code and it appears we never call this as part of the test. Let me know in case I am wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org