You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by Zhangshunyu <gi...@git.apache.org> on 2016/10/21 21:51:26 UTC
[GitHub] incubator-carbondata pull request #254: [CARBONDATA-326] Creates wrong table...
GitHub user Zhangshunyu opened a pull request:
https://github.com/apache/incubator-carbondata/pull/254
[CARBONDATA-326] Creates wrong table on 'create table like'
## Why raise this pr?
For fix this problem on jira:
```
I'm trying to create a table like my old table but it is not creating as expected.
0: jdbc:hive2://localhost:10000> CREATE TABLE mainTable(id INT, name STRING) STORED BY 'carbondata';
---------+
Result
---------+
---------+
No rows selected (0.206 seconds)
0: jdbc:hive2://localhost:10000> DESC mainTable;
-----------------------------+
col_name data_type comment
-----------------------------+
name string
id bigint
-----------------------------+
2 rows selected (0.056 seconds)
Above one is my mainTable and I wants to create copiedTable from it but everytime it is show something like:
0: jdbc:hive2://localhost:10000> CREATE TABLE copiedTable LIKE mainTable;
---------+
result
---------+
---------+
No rows selected (0.101 seconds)
0: jdbc:hive2://localhost:10000> DESC copiedTable;
-------------------------------------------+
col_name data_type comment
-------------------------------------------+
col array<string> from deserializer
-------------------------------------------+
1 row selected (0.022 seconds)
0: jdbc:hive2://localhost:10000> LOAD DATA LOCAL INPATH 'hdfs://localhost:54310/user/hduser/datafiles/data.csv' INTO TABLE copiedTable OPTIONS('DELIMITER'=',');
Error: java.lang.RuntimeException: Data loading failed. table not found: knoldus.copiedtable (state=,code=0)
```
Since carbon not supprut 'create table like', when the table is carbon table, we should throw error to the user and not create such a table, meanwhile, we should also not have effect on hive tables.
## How to test?
Pass all the test cases and the new added testcase.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zhangshunyu/incubator-carbondata createlike
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #254
----
commit 0af3a8150ef5821c4c4a4fc0aa3df1b03694da64
Author: Zhangshunyu <zh...@huawei.com>
Date: 2016-10-21T21:30:43Z
Carbon not supprt 'create table like' and hive support
commit 224216d1005cb49331e9bf62a628144d7495fd66
Author: Zhangshunyu <zh...@huawei.com>
Date: 2016-10-21T21:45:20Z
Carbon not supprt 'create table like' and hive support
commit 4acfd3c8e8b63075fdff3f510290be11827c18e0
Author: Zhangshunyu <zh...@huawei.com>
Date: 2016-10-21T21:47:48Z
Carbon not supprt 'create table like' and hive support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
Could anyone pls review this pr\uff1f
@jackylk @ravipesala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
Build Success, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/32/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
please rebase.
And why it can not support create table like carbon table? It just need the schema of the like table, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #254: [CARBONDATA-326] Create wrong table ...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #254: [CARBONDATA-326] Create wrong table ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/254#discussion_r84686198
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonCatalystOperators.scala ---
@@ -90,3 +90,11 @@ abstract class CarbonProfile(attributes: Seq[Attribute]) extends Serializable {
case class IncludeProfile(attributes: Seq[Attribute]) extends CarbonProfile(attributes)
case class ExcludeProfile(attributes: Seq[Attribute]) extends CarbonProfile(attributes)
+
+case class CreateLikeTable(likeTableName: String, createHiveLikeTableSql: String)
--- End diff --
please add description to the parameters
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
Build Failed, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
Build Failed, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
Build Failed, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/31/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/149/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #254: [CARBONDATA-326] Create wrong table using '...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu commented on the issue:
https://github.com/apache/incubator-carbondata/pull/254
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---