You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by mm...@apache.org on 2019/04/08 17:26:21 UTC

[accumulo] branch milleruntime-contributing-patch created (now b461180)

This is an automated email from the ASF dual-hosted git repository.

mmiller pushed a change to branch milleruntime-contributing-patch
in repository https://gitbox.apache.org/repos/asf/accumulo.git.


      at b461180  Update CONTRIBUTING.md

This branch includes the following new commits:

     new b461180  Update CONTRIBUTING.md

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[accumulo] 01/01: Update CONTRIBUTING.md

Posted by mm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mmiller pushed a commit to branch milleruntime-contributing-patch
in repository https://gitbox.apache.org/repos/asf/accumulo.git

commit b461180398615394ef9b33fb2b7be1b902b8abca
Author: Mike Miller <mm...@apache.org>
AuthorDate: Mon Apr 8 13:26:14 2019 -0400

    Update CONTRIBUTING.md
---
 CONTRIBUTING.md | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index e1f2eb0..64ca545 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -34,10 +34,5 @@ limitations under the License.
 ## Review
 
 - We welcome reviews from anyone. Any committer can approve and merge the changes.
-- Reviewers will be looking for things like threading issues, performance implications, API design, etc.
-- Reviewers will likely ask questions to better understand your change.
-- Reviewers will make comments about changes to your patch:
-    - MUST means that the change is required
-    - SHOULD means that the change is suggested, further discussion on the subject may be required
-    - COULD means that the change is optional
+- Reviewers will likely ask questions to better understand your change and follow these [guidelines](https://tools.ietf.org/html/rfc2119).