[GitHub] [arrow-datafusion] Nukesor commented on issue #6524: array_agg panics on large rows.

["Nukesor (via GitHub)" <gi...@apache.org>]

Nukesor commented on issue #6524:
URL: https://github.com/apache/arrow-datafusion/issues/6524#issuecomment-1590490691

   Hey :)
   
   In comfy-table, I went with the approach to choose a `u16` for table widths, since this covered all use-cases I could come up with. This allows the user to build tables that're `65535` characters wide.
   
   If there's some content that's longer than 65535 chars, the table width is internally fixed to that `u16::MAX`, but the formatting can look a bit wonky, since the actual content can be even longer than `65535` chars.
   However, I consider this a non-issue, since no user will ever have a screen wide enough to display that many chars and the output on your terminal will be botched anyway.
   In case a user wants proper formatting, there's the `Dynamic` content adjustment mode, which introduces line-breaks to fit the content to the current/specified terminal width.
   
   I already tried to use the appropriate `saturating_[sub|add]` functions everywhere, but it seems I overlooked a few places. A PR https://github.com/Nukesor/comfy-table/pull/114 has been opened, but it would be awesome, if you somebdoy could test this or even write a regression test case to trigger the panic on the current code-base.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org