[GitHub] spark pull request #15987: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...

[viirya <gi...@git.apache.org>]

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15987#discussion_r90797605
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ---
    @@ -661,6 +661,36 @@ class Analyzer(
           // rule: ResolveDeserializer.
           case plan if containsDeserializer(plan.expressions) => plan
     
    +      // Some commands (AlterTableDropPartitionCommand) use expressions, so we need to resolve.
    +      case c: CommandWithExpression =>
    +        val catalogTable = catalog.getTableMetadata(c.getTableName)
    +
    +        // We should not do this here in order to support general CommandWithExpression
    +        if (catalogTable.tableType == CatalogTableType.VIEW) {
    +          throw new AnalysisException(
    +            "Cannot alter a view with ALTER TABLE. Please use ALTER VIEW instead")
    --- End diff --
    
    Except `AlterTableDropPartitionCommand`, do we have other running commands which need this resolving? If not, I think we may not need to add this to `Analyzer` and create new abstraction `CommandWithExpression`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org