[GitHub] [avro] KalleOlaviNiemitalo commented on a diff in pull request #1756: AVRO-3571: Shifted integer and long constants to constants.py

[GitBox <gi...@apache.org>]

KalleOlaviNiemitalo commented on code in PR #1756:
URL: https://github.com/apache/avro/pull/1756#discussion_r916480081


##########
lang/py/avro/io.py:
##########
@@ -205,12 +204,11 @@ def _map_iterator(node: ValidationNode) -> ValidationNodeGeneratorType:
 
 class BinaryDecoder:
     """Read leaf values."""
-
     _reader: IO[bytes]
 
     def __init__(self, reader: IO[bytes]) -> None:
         """
-        reader is a Python object on which we can call read, seek, and tell.
+        Reader is a Python object on which we can call read, seek, and tell.

Review Comment:
   If that refers to the `reader` parameter, then perhaps it would be better to keep it in lower case. Not a strong opinion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org