You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/20 14:50:46 UTC
[GitHub] srowen commented on a change in pull request #23845:
[SPARK-26941][YARN]Fix incorrect computation of maxNumExecutorFailures in
ApplicationMaster for streaming
srowen commented on a change in pull request #23845: [SPARK-26941][YARN]Fix incorrect computation of maxNumExecutorFailures in ApplicationMaster for streaming
URL: https://github.com/apache/spark/pull/23845#discussion_r258488508
##########
File path: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
##########
@@ -190,23 +191,10 @@ private[streaming] class ExecutorAllocationManager(
}
private[streaming] object ExecutorAllocationManager extends Logging {
- val ENABLED_KEY = "spark.streaming.dynamicAllocation.enabled"
-
- val SCALING_INTERVAL_KEY = "spark.streaming.dynamicAllocation.scalingInterval"
- val SCALING_INTERVAL_DEFAULT_SECS = 60
-
- val SCALING_UP_RATIO_KEY = "spark.streaming.dynamicAllocation.scalingUpRatio"
- val SCALING_UP_RATIO_DEFAULT = 0.9
-
- val SCALING_DOWN_RATIO_KEY = "spark.streaming.dynamicAllocation.scalingDownRatio"
- val SCALING_DOWN_RATIO_DEFAULT = 0.3
-
- val MIN_EXECUTORS_KEY = "spark.streaming.dynamicAllocation.minExecutors"
-
- val MAX_EXECUTORS_KEY = "spark.streaming.dynamicAllocation.maxExecutors"
def isDynamicAllocationEnabled(conf: SparkConf): Boolean = {
- val streamingDynamicAllocationEnabled = conf.getBoolean(ENABLED_KEY, false)
+ val streamingDynamicAllocationEnabled = Utils.isStreamingDynamicAllocationEnabled(conf)
+ Utils.isStreamingDynamicAllocationEnabled(conf)
Review comment:
This line looks like it should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org