You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/21 02:34:40 UTC
[commons-imaging] branch master updated (2f4adfe -> cff708e)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git.
from 2f4adfe Remove redundant call to super().
new 319431c Travis: Replace Java 14 with 15. One Java 11 build.
new cff708e No need to initialize to default value.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.travis.yml | 3 +--
.../java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java | 4 +---
.../org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
[commons-imaging] 02/02: No need to initialize to default value.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
commit cff708e803bf88358e892251e61d0d9992ab443a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 21:34:35 2020 -0500
No need to initialize to default value.
---
.../java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java | 4 +---
.../org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java | 3 +--
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
index 4bd6d72..288c239 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
@@ -804,9 +804,7 @@ public class JpegImageParser extends ImageParser implements XmpEmbeddable {
final List<String> comments = new ArrayList<>(commentSegments.size());
for (final Segment commentSegment : commentSegments) {
final ComSegment comSegment = (ComSegment) commentSegment;
- String comment = "";
- comment = new String(comSegment.getComment(), StandardCharsets.UTF_8);
- comments.add(comment);
+ comments.add(new String(comSegment.getComment(), StandardCharsets.UTF_8));
}
final int numberOfComponents = fSOFNSegment.numberOfComponents;
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java
index e292532..c40940d 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java
@@ -392,8 +392,7 @@ public class ExifRewriter extends BinaryFileParser {
// Just use first APP1 segment for now.
// Multiple APP1 segments are rare and poorly supported.
if (!jfifPieces.exifPieces.isEmpty()) {
- JFIFPieceSegment exifPiece = null;
- exifPiece = (JFIFPieceSegment) jfifPieces.exifPieces.get(0);
+ final JFIFPieceSegment exifPiece = (JFIFPieceSegment) jfifPieces.exifPieces.get(0);
byte[] exifBytes = exifPiece.segmentData;
exifBytes = remainingBytes("trimmed exif bytes", exifBytes, 6);
[commons-imaging] 01/02: Travis: Replace Java 14 with 15. One Java
11 build.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
commit 319431c7cb692f92cb383cd1e7534de4307dc0ae
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 21:33:44 2020 -0500
Travis: Replace Java 14 with 15. One Java 11
build.
---
.travis.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index faee3c9..a5d3f4a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,10 +19,9 @@ cache:
directories:
- $HOME/.m2
jdk:
- - oraclejdk11
- openjdk8
- openjdk11
- - openjdk14
+ - openjdk15
- openjdk-ea
matrix: