You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/16 13:09:25 UTC
[GitHub] [incubator-nuttx] fjpanag opened a new pull request #2697: Added printing of log priority in syslog.
fjpanag opened a new pull request #2697:
URL: https://github.com/apache/incubator-nuttx/pull/2697
## Summary
Adds the ability to print the message priority in syslog.
## Impact
None. Defaults to the old behaviour.
## Testing
Tested both configurations (with and without priority logging) on custom STM32F4 target, and the messages are formatted correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2697: Added printing of log priority in syslog.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2697:
URL: https://github.com/apache/incubator-nuttx/pull/2697#discussion_r558902201
##########
File path: drivers/syslog/vsyslog.c
##########
@@ -50,6 +50,16 @@
#include <nuttx/streams.h>
#include <nuttx/syslog/syslog.h>
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static const char * priority_str[] =
+ {
Review comment:
need add FAR and g_ too:
```
static FAR const char * g_priority_str[] =
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2697: Added printing of log priority in syslog.
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #2697:
URL: https://github.com/apache/incubator-nuttx/pull/2697#discussion_r558879834
##########
File path: drivers/syslog/vsyslog.c
##########
@@ -50,6 +50,16 @@
#include <nuttx/streams.h>
#include <nuttx/syslog/syslog.h>
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static const char * priority_str[] =
+ {
Review comment:
Shouldn't this be enclosed in
#if defined(CONFIG_SYSLOG_PRIORITY)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #2697: Added printing of log priority in syslog.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on a change in pull request #2697:
URL: https://github.com/apache/incubator-nuttx/pull/2697#discussion_r558884202
##########
File path: drivers/syslog/vsyslog.c
##########
@@ -50,6 +50,16 @@
#include <nuttx/streams.h>
#include <nuttx/syslog/syslog.h>
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static const char * priority_str[] =
+ {
Review comment:
@patacongo It seems it is correct now. Sorry for this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #2697: Added printing of log priority in syslog.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on a change in pull request #2697:
URL: https://github.com/apache/incubator-nuttx/pull/2697#discussion_r558883414
##########
File path: drivers/syslog/vsyslog.c
##########
@@ -50,6 +50,16 @@
#include <nuttx/streams.h>
#include <nuttx/syslog/syslog.h>
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static const char * priority_str[] =
+ {
Review comment:
Yes, it is.
Seems like I pushed the wrong commit. There are also formatting fixes.
Pushing again now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #2697: Added printing of log priority in syslog.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on a change in pull request #2697:
URL: https://github.com/apache/incubator-nuttx/pull/2697#discussion_r558908348
##########
File path: drivers/syslog/vsyslog.c
##########
@@ -50,6 +50,16 @@
#include <nuttx/streams.h>
#include <nuttx/syslog/syslog.h>
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+static const char * priority_str[] =
+ {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2697: Added printing of log priority in syslog.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2697:
URL: https://github.com/apache/incubator-nuttx/pull/2697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org