[jira] Updated: (OFBIZ-583) Offline payment selection now prevents completion of sales order

["Iain Fogg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Iain Fogg updated OFBIZ-583:
----------------------------

    Attachment: CheckOutEvents.patch

All,

Sorry it's been a while, but I've had a hard time getting spare cycles to do the right thing and generate a patch. My latest update from the repository is r491209, against which I've generated the patch file. I realise this is almost a month old; I'll be trying to upgrade this weekend and can regenerate the patch if it causes problems for other people (i.e., if CheckOutEvents.java has changed significantly in the last few weeks).

FYI, I've been running this patch for the last month and have had no problems, although you should be aware that I don't do any online payments.

- Iain

> Offline payment selection now prevents completion of sales order
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-583
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-583
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Critical
>         Attachments: CheckOutEvents.patch
>
>
> I upgraded to the latest SVN on the weekend and now I find that when I raise a Sales Order in the Order Manager, and select OFFLINE as the payment option, the sale cannot proceed because it complains about no payment method being selected.
> CheckOutEvent.java has undergone some significant changes regarding checkout processing, and I suspect the following snippet:
>         methodType = request.getParameter("paymentMethodType");
>         if ("offline".equals(methodType)) {
>             Debug.log("Changing mode from->to: " + mode + "->payment", module);
>             mode = "payment";
>         }
> If I've selected offline payment, shouldn't the mode be set to "addparty", not "payment"?
> Not sure who contributed the most recent changes, but would appreciate a speedy resolution to this one as I can't do sales orders without it!!!
> Cheers, Iain

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.