You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/02/02 20:20:46 UTC

[kudu-CR] Adds HAS CLMUL to control inclusion of HW carryless multiply

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19446 )

Change subject: Adds HAS_CLMUL to control inclusion of HW carryless multiply
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

LGTM, just a couple of formatting nits in CMakeLists.txt

http://gerrit.cloudera.org:8080/#/c/19446/1/CMakeLists.txt
File CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/19446/1/CMakeLists.txt@197
PS1, Line 197:  
nit: drop this extra space?


http://gerrit.cloudera.org:8080/#/c/19446/1/CMakeLists.txt@198
PS1, Line 198:          
nit: to comply with the convention used in this file, please use two spaces for this indent



-- 
To view, visit http://gerrit.cloudera.org:8080/19446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05fd3a50ee545698db8766cdb39097314a0dc6d2
Gerrit-Change-Number: 19446
Gerrit-PatchSet: 1
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Feb 2023 20:20:46 +0000
Gerrit-HasComments: Yes