[GitHub] [airflow] mik-laj commented on a change in pull request #8895: AddDelete/Create S3 bucket operators

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #8895:
URL: https://github.com/apache/airflow/pull/8895#discussion_r426298861



##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -664,6 +664,23 @@ def copy_object(self,
                                                ACL=acl_policy)
         return response
 
+    @provide_bucket_name
+    def delete_bucket(self, bucket_name) -> None:
+        """
+        To delete s3 bucket, delete all s3 bucket objects and then delete the bucket.
+
+        :param bucket: Bucket name

Review comment:
       ```suggestion
           :param bucket_name: Bucket name
   ```

##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -664,6 +664,23 @@ def copy_object(self,
                                                ACL=acl_policy)
         return response
 
+    @provide_bucket_name
+    def delete_bucket(self, bucket_name) -> None:
+        """
+        To delete s3 bucket, delete all s3 bucket objects and then delete the bucket.
+
+        :param bucket: Bucket name
+        :type bucket: str

Review comment:
       ```suggestion
           :type bucket_name: str
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org