You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2010/04/07 23:38:42 UTC

svn commit: r931698 - in /hadoop/hbase/trunk: CHANGES.txt core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

Author: stack
Date: Wed Apr  7 21:38:42 2010
New Revision: 931698

URL: http://svn.apache.org/viewvc?rev=931698&view=rev
Log:
HBASE-2419 Remove from RS logs the fat NotServingRegionException stack

Modified:
    hadoop/hbase/trunk/CHANGES.txt
    hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
    hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=931698&r1=931697&r2=931698&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Wed Apr  7 21:38:42 2010
@@ -485,6 +485,7 @@ Release 0.21.0 - Unreleased
                holds up all flushing
    HBASE-2252  Mapping a very big table kills region servers
    HBASE-2412  [stargate] PerformanceEvaluation
+   HBASE-2419  Remove from RS logs the fat NotServingRegionException stack
 
   NEW FEATURES
    HBASE-1961  HBase EC2 scripts

Modified: hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=931698&r1=931697&r2=931698&view=diff
==============================================================================
--- hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (original)
+++ hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java Wed Apr  7 21:38:42 2010
@@ -1661,7 +1661,7 @@ public class HRegion implements HConstan
     splitsAndClosesLock.readLock().lock();
     try {
       if (this.closed.get()) {
-        throw new NotServingRegionException("Region " + this + " closed");
+        throw new NotServingRegionException(this + " is closed");
       }
       synchronized (lockedRows) {
         while (lockedRows.contains(row)) {

Modified: hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java?rev=931698&r1=931697&r2=931698&view=diff
==============================================================================
--- hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (original)
+++ hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Wed Apr  7 21:38:42 2010
@@ -1416,7 +1416,7 @@ public class HRegionServer implements HC
                   + e.msg.toString());
             }
           } catch (InterruptedException ex) {
-            // continue
+            LOG.warn("Processing Worker queue", ex);
           } catch (Exception ex) {
             if (ex instanceof IOException) {
               ex = RemoteExceptionHandler.checkIOException((IOException) ex);
@@ -1714,7 +1714,8 @@ public class HRegionServer implements HC
       LOG.debug("Batch puts: " + i, ex);
       return i;
     } catch (NotServingRegionException ex) {
-      LOG.debug("Batch puts: " + i, ex);
+      LOG.debug("Batch puts interrupted at index=" + i + " because:" +
+        ex.getMessage());
       return i;
     } catch (Throwable t) {
       throw convertThrowableToIOE(cleanup(t));
@@ -2427,5 +2428,4 @@ public class HRegionServer implements HC
 
     return resp;
   }
-
 }