[impala] 01/02: Reapply IMPALA-9128: part 2: dump traces for slow RPCs

[bo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit c8f1034f30671d997f770a8f7f037deac186ae8c
Author: Tim Armstrong <ta...@cloudera.com>
AuthorDate: Thu Nov 7 15:13:05 2019 -0800

    Reapply IMPALA-9128: part 2: dump traces for slow RPCs
    
    This change was accidentally reverted in the KRPC rebase.
    
    It will be upstreamed to Kudu as KUDU-2996.
    
    Change-Id: Ic6800b68f61e84420e138bfad67a40be3796b4df
    Reviewed-on: http://gerrit.cloudera.org:8080/15198
    Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/kudu/rpc/rpcz_store.cc | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/be/src/kudu/rpc/rpcz_store.cc b/be/src/kudu/rpc/rpcz_store.cc
index f7c7b3b..0f5f666 100644
--- a/be/src/kudu/rpc/rpcz_store.cc
+++ b/be/src/kudu/rpc/rpcz_store.cc
@@ -267,7 +267,11 @@ void RpczStore::LogTrace(InboundCall* call) {
     call->trace()->Dump(&LOG(INFO), true);
   } else if (duration_ms > FLAGS_rpc_duration_too_long_ms) {
     LOG(INFO) << call->ToString() << " took " << duration_ms << "ms. "
-              << "Request Metrics: " << call->trace()->MetricsAsJSON();
+              << "Request Metrics: " << call->trace()->MetricsAsJSON() << "\n";
+    string s = call->trace()->DumpToString();
+    if (!s.empty()) {
+      LOG(INFO) << "Trace:\n" << s;
+    }
   }
 }