[GitHub] [bookkeeper] dlg99 opened a new pull request, #3869: [fix][gc] Change order of doGcLedgers and extractMetaFromEntryLogs

["dlg99 (via GitHub)" <gi...@apache.org>]

dlg99 opened a new pull request, #3869:
URL: https://github.com/apache/bookkeeper/pull/3869

   ### Motivation
   
   Garbage collector does
   ```
    extractMetaFromEntryLogs();
    doGcLedgers();
   ```
   
   where extractMetaFromEntryLogs checks if ledger exists in the storage and doGcLedgers removes deleted ledgers from the storage.
   
   Logically, these should be reordered.
   Currently it means that deleted ledgers will be either re-verified during compaction and skipped (if verifyMetadataOnGC is true) or picked up on the next GC run.  
   
   The tests pass as they end to do
   ```
           getGCThread().enableForceGC();
           getGCThread().triggerGC().get();
   ```
   where both of these calls trigger gc.
   
   In prod it means data released later
   
   ### Changes
   
   reordered operations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli merged pull request #3869: [fix][gc] Change order of doGcLedgers and extractMetaFromEntryLogs

["eolivelli (via GitHub)" <gi...@apache.org>]

eolivelli merged PR #3869:
URL: https://github.com/apache/bookkeeper/pull/3869


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org