You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/10 15:04:17 UTC

[GitHub] [tvm] giuseros commented on a change in pull request #7009: [TFLite] Bugfix - ensure pad calcalution to be in int32

giuseros commented on a change in pull request #7009:
URL: https://github.com/apache/tvm/pull/7009#discussion_r540240975



##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -3210,7 +3210,7 @@ def get_pad_value(data, kernel, stride):
     """
 
     out = int(math.ceil(float(data) / float(stride)))
-    pad = max(0, (out - 1) * stride + kernel - data)
+    pad = max(0, (out - 1) * int(stride) + int(kernel) - int(data))

Review comment:
       Also, do we know why this fails with `int64`? AFAIU from your RFC: https://discuss.tvm.apache.org/t/int64-vs-int32-dtype-error/8555 this used to work before. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org